Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment use of macupdate #6567

Merged
merged 3 commits into from
Oct 9, 2014
Merged

Comment use of macupdate #6567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
985729a
comment/caveat use of macupdate in ap-grapher.rb
rolandwalker Oct 9, 2014
ad1c30a
comment/caveat use of macupdate in icursor.rb
rolandwalker Oct 9, 2014
5522604
comment/caveat use of macupdate in multibrowser.rb
rolandwalker Oct 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Casks/ap-grapher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,17 @@ class ApGrapher < Cask
version :latest
sha256 :no_check

# macupdate is used because the vendor homepage is abandoned
# (http://www.chimoosoft.com/products/apgrapher/)
url 'https://www.macupdate.com/download/11859/APGrapher.dmg'
homepage 'https://www.macupdate.com/app/mac/11859/ap-grapher'
license :unknown

app 'AP Grapher.app'

caveats <<-EOS.undent
Warning: #{title} has been abandoned by its author, and the
vendor homepage is defunct. This Cask downloads an untrusted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the double-spacing intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was, because terminal outputs are monospaced. Is that bad?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s something I’d correct to a single space (for stylistic reasons) if I found it in a cask. I was asking to know if it’s something I should leave be in the future (because it was intentional), or something you missed.

I may have made such changes in the past, so I was asking for the opposite reason: to know if it was bad to have it as a single space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it slightly more readable for monospace, but it's not a strong preference. My editor is configured that way, so it happens without thinking.

Either convention is fine. But it would probably save effort at this point to have a short English style guide (probably in HACKING.md?). Naive wc says we have 20K words of Markdown, plus uncounted message strings and caveats.

copy from an alternative source.
EOS
end
8 changes: 8 additions & 0 deletions Casks/icursor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,17 @@ class Icursor < Cask
version :latest
sha256 :no_check

# macupdate is used because the vendor homepage is abandoned
# (http://www.giofx.net/GioFX/MacOS.html)
url 'https://www.macupdate.com/download/17059/iCursor.zip'
homepage 'https://www.macupdate.com/app/mac/17059/icursor'
license :unknown

app 'iCursor.app'

caveats <<-EOS.undent
Warning: #{title} has been abandoned by its author, and the
vendor homepage is defunct. This Cask downloads an untrusted
copy from an alternative source.
EOS
end
7 changes: 7 additions & 0 deletions Casks/multibrowser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,16 @@ class Multibrowser < Cask
version :latest
sha256 :no_check

# macupdate is the official download host per the vendor homepage
url 'https://www.macupdate.com/download/33861/MultiBrowser.dmg'
homepage 'https://sites.google.com/site/tesseractsoftware/multibrowser'
license :unknown

app 'MultiBrowser.app'

caveats <<-EOS.undent
Warning: #{title} has been abandoned by its author, and the
vendor homepage is defunct. This Cask downloads an untrusted
copy from an alternative source.
EOS
end