-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment use of macupdate #6567
Comment use of macupdate #6567
Conversation
As per #6568, we could also add Big thumbs up on showing a warning in these cases. Making a note that we should also change |
It seems like a good thing that we have not included That is a sign that the term "abandoned" is too fuzzy or subjective. The last thing we want to do is introduce a squishy term which causes maintenance load as different Cask authors use it in different ways. While it would be clever to automatically print warnings on |
Proposing We should also probably move all the casks with such a license to caskroom/versions (the more I think about, the more it makes sense, to me). |
66a4107
to
5522604
Compare
|
||
caveats <<-EOS.undent | ||
Warning: #{title} has been abandoned by its author, and the | ||
vendor homepage is defunct. This Cask downloads an untrusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the double-spacing intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was, because terminal outputs are monospaced. Is that bad?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s something I’d correct to a single space (for stylistic reasons) if I found it in a cask. I was asking to know if it’s something I should leave be in the future (because it was intentional), or something you missed.
I may have made such changes in the past, so I was asking for the opposite reason: to know if it was bad to have it as a single space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it slightly more readable for monospace, but it's not a strong preference. My editor is configured that way, so it happens without thinking.
Either convention is fine. But it would probably save effort at this point to have a short English style guide (probably in HACKING.md?). Naive wc
says we have 20K words of Markdown, plus uncounted message strings and caveats.
@vitorgalvao, @ndr-qef, the first two are cases where I would use
license :abandoned
.It would seem prudent to print a warning in such cases.