Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment use of macupdate #6567

Merged
merged 3 commits into from
Oct 9, 2014

Conversation

rolandwalker
Copy link
Contributor

@vitorgalvao, @ndr-qef, the first two are cases where I would use license :abandoned.

It would seem prudent to print a warning in such cases.

@vitorgalvao
Copy link
Member

As per #6568, we could also add license :abandoned to growl-fork, as opposed to removing it (although I wouldn’t be opposed to adding the license and moving it to caskroom/versions).

Big thumbs up on showing a warning in these cases.

Making a note that we should also change diskaid’s license (it was discontinued in the sense that its new version has a different name).

@rolandwalker
Copy link
Contributor Author

It seems like a good thing that we have not included license :abandoned yet. I devised it to mean "the vendor is gone, or the product is canceled". You would use it to mean "the vendor still here, but this is no longer kept up to date".

That is a sign that the term "abandoned" is too fuzzy or subjective. The last thing we want to do is introduce a squishy term which causes maintenance load as different Cask authors use it in different ways.

While it would be clever to automatically print warnings on license :abandoned, we have to think of an unambiguous term. In the meantime, this is a short list of Casks: I'll just push some caveats to this PR.

@vitorgalvao
Copy link
Member

Proposing license :discontinued, or license :sunset (absolutely joking, on this last one).

We should also probably move all the casks with such a license to caskroom/versions (the more I think about, the more it makes sense, to me).


caveats <<-EOS.undent
Warning: #{title} has been abandoned by its author, and the
vendor homepage is defunct. This Cask downloads an untrusted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the double-spacing intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was, because terminal outputs are monospaced. Is that bad?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s something I’d correct to a single space (for stylistic reasons) if I found it in a cask. I was asking to know if it’s something I should leave be in the future (because it was intentional), or something you missed.

I may have made such changes in the past, so I was asking for the opposite reason: to know if it was bad to have it as a single space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it slightly more readable for monospace, but it's not a strong preference. My editor is configured that way, so it happens without thinking.

Either convention is fine. But it would probably save effort at this point to have a short English style guide (probably in HACKING.md?). Naive wc says we have 20K words of Markdown, plus uncounted message strings and caveats.

rolandwalker added a commit that referenced this pull request Oct 9, 2014
@rolandwalker rolandwalker merged commit ca46550 into Homebrew:master Oct 9, 2014
@rolandwalker rolandwalker deleted the comment_aggregators branch October 9, 2014 20:55
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants