Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove growl-fork #6568

Closed
wants to merge 1 commit into from
Closed

Remove growl-fork #6568

wants to merge 1 commit into from

Conversation

tapeinosyne
Copy link
Contributor

growl-fork is an unofficial build of dubious maintainace status. We should either move it to caskroom/versions, or abandon it altogether, as Growl has been superseded by native notifications in recent OS X releases.

If merged, closes #6564.

Unofficial build.
@rolandwalker
Copy link
Contributor

I oppose the principle rather strongly, as the fresh/stale decision is subjective, and the scale changes based on the type of binary. Subjectivity doesn't scale to where we are, and where we are headed.

As to this particular distribution, it is an unusual case, and not surprising to see few commits.

When Growl went commercial back at version 1.3, they purposely stopped providing the open source version, or allowed it to stop working with an OS X update. I can't remember exactly, but the effect was to force users into the paid version.

This kind individual took the last-public version of the OSS codebase, made the necessary changes to make it run, and released it. The primary use-case here is backwards compatibility. This version preserves the 1.2 version of the Growl API, including the old-style networked notifications, which were removed in Growl 1.3.

@tapeinosyne
Copy link
Contributor Author

The main argument for removal is the unofficial status. If circumstances dictate that an exception to our guidelines would be beneficial, I have no qualm with closing.

@lukateras
Copy link

Upstream OSS Growl is currently abandoned. This fork can be seen as a patchset for original Growl to make it actually work on modern versions of OS X.

I vote for leaving it as it is in this repo and maybe renaming it to just growl. You can't mix this one and the commercial one since the latter can be downloaded only through Appstore.

At least, nothing is said about -fork suffix in the reference.

@vitorgalvao
Copy link
Member

I vote for leaving it as it is in this repo and maybe renaming it to just growl.

No can do. We either leave it as it is, or we delete it/move it to another repo.

You can't mix this one and the commercial one since the latter can be downloaded only through Appstore.

To get to this conclusion, you have to both know for sure growl is only available on the MAS and be aware of our policy to not include software that can only be bought from there. Not all users will know that, and we should not be ambiguous.

@rolandwalker
Copy link
Contributor

@vitorgalvao agreed. This just came up in #6747. Historically, we have included multiple forks here sometimes (there are three versions of GitX.app). But we have a responsibility to provide the branded upstream under its appropriate name. In the case of Chromium, I'm sure that the name is trademarked, and thus we are probably legally required to not mislabel the brand.

@yegortimoschenko the -fork suffix is from before we standardized the naming scheme. But we didn't change it to pmetzger-growl.rb because it is branded in most places as "Growl Fork". That can be confusing, and I would support re-naming our various forks strictly according to <vendor>-<name>.rb. We now have tag :name to create some other searchable text within the Cask for these odd cases:

tag :name => 'Growl Fork'

though I haven't yet hooked up brew cask search to that info.

@vitorgalvao
Copy link
Member

I would support re-naming our various forks strictly according to <vendor>-<name>.rb. We now have tag :name to create some other searchable text within the Cask for these odd cases

Seems like the best option to me, as well. We already use the vendor name to differentiate apps with the same name that are not forks of one another, so it’s a natural progression to extend that to these cases.

@tapeinosyne
Copy link
Contributor Author

The consensus is to rename growl-fork to pmetzger-growl and keep it in the main repository. Closing.

@tapeinosyne tapeinosyne deleted the remove/growl-fork branch October 22, 2014 08:31
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants