-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove growl-fork #6568
Remove growl-fork #6568
Conversation
Unofficial build.
I oppose the principle rather strongly, as the fresh/stale decision is subjective, and the scale changes based on the type of binary. Subjectivity doesn't scale to where we are, and where we are headed. As to this particular distribution, it is an unusual case, and not surprising to see few commits. When Growl went commercial back at version 1.3, they purposely stopped providing the open source version, or allowed it to stop working with an OS X update. I can't remember exactly, but the effect was to force users into the paid version. This kind individual took the last-public version of the OSS codebase, made the necessary changes to make it run, and released it. The primary use-case here is backwards compatibility. This version preserves the 1.2 version of the Growl API, including the old-style networked notifications, which were removed in Growl 1.3. |
The main argument for removal is the unofficial status. If circumstances dictate that an exception to our guidelines would be beneficial, I have no qualm with closing. |
Upstream OSS Growl is currently abandoned. This fork can be seen as a patchset for original Growl to make it actually work on modern versions of OS X. I vote for leaving it as it is in this repo and maybe renaming it to just At least, nothing is said about |
No can do. We either leave it as it is, or we delete it/move it to another repo.
To get to this conclusion, you have to both know for sure growl is only available on the MAS and be aware of our policy to not include software that can only be bought from there. Not all users will know that, and we should not be ambiguous. |
@vitorgalvao agreed. This just came up in #6747. Historically, we have included multiple forks here sometimes (there are three versions of GitX.app). But we have a responsibility to provide the branded upstream under its appropriate name. In the case of Chromium, I'm sure that the name is trademarked, and thus we are probably legally required to not mislabel the brand. @yegortimoschenko the tag :name => 'Growl Fork' though I haven't yet hooked up |
Seems like the best option to me, as well. We already use the vendor name to differentiate apps with the same name that are not forks of one another, so it’s a natural progression to extend that to these cases. |
The consensus is to rename |
growl-fork
is an unofficial build of dubious maintainace status. We should either move it to caskroom/versions, or abandon it altogether, as Growl has been superseded by native notifications in recent OS X releases.If merged, closes #6564.