remove support for title method in Casks
#7825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
added
the
core
|
Do we have this one already covered in some branch? |
|
No, missed that — thanks. @phinze wants us to switch everything to RSpec, and he got us started, but I haven't learned anything about it yet. |
|
Just did a full-text search which yielded just one more occurrence of Other than that, and apart from the two PRs on whom this one depends, LGTM 👍 |
rolandwalker
force-pushed
the
remove_title_support
branch
from
f353ebe to
2ac4bac
Compare
|
And that's why I need review! |
obsoleted by `token`
rolandwalker
force-pushed
the
remove_title_support
branch
from
2ac4bac to
a6bc35c
Compare
rolandwalker
changed the title
title method in Caskstitle method in Casks
rolandwalker
added a commit
that referenced
this pull request
Dec 6, 2014
remove support for `title` method in Casks
miccal
removed
the
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obsoleted by
tokenHOLD until #7820 and Homebrew/homebrew-cask-versions#589