Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for title method in Casks #7825

Merged
merged 1 commit into from
Dec 6, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions lib/cask.rb
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,6 @@ def self.token
self.name.gsub(/([a-zA-Z\d])([A-Z])/,'\1-\2').gsub(/([a-zA-Z\d])([A-Z])/,'\1-\2').downcase
end

# todo removeme transitional backward-compatibility
def self.title
self.token
end

def self.nowstamp_metadata_path(container_path)
@timenow ||= Time.now.gmtime
if container_path.respond_to?(:join)
Expand All @@ -105,11 +100,6 @@ def initialize(token=self.class.token)
@token = token
end

# todo removeme transitional backward-compatibility
def title
@token
end

def caskroom_path
self.class.caskroom.join(token)
end
Expand Down
5 changes: 0 additions & 5 deletions lib/cask/caveats.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ def token
@cask.token
end

# todo removeme transitional backward compatibility
def title
@cask.token
end

def version
@cask.version
end
Expand Down
2 changes: 1 addition & 1 deletion lib/cask/dsl.rb
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def sha256(sha2=nil)
end

def method_missing(method, *args)
Cask::Utils.method_missing_message(method, self.title)
Cask::Utils.method_missing_message(method, self.token)
return nil
end
end
Expand Down
5 changes: 0 additions & 5 deletions lib/cask/dsl/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ def token
@cask.token
end

# todo removeme transitional backward compatibility
def title
@cask.token
end

def version
@cask.version
end
Expand Down
5 changes: 0 additions & 5 deletions lib/cask/source/tapped.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ def initialize(token)
@token = token
end

# todo removeme transitional backward-compatibility
def title
@token
end

def load
path = self.class.path_for_query(token)
Cask::Source::PathSlashOptional.new(path).load
Expand Down
2 changes: 1 addition & 1 deletion spec/cask/download_strategy_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
let(:url_options) { Hash.new }
let(:cask) {
class_double(Cask,
:title => 'some-cask',
:token => 'some-cask',
:url => Cask::URL.new(url, url_options),
:version => '1.2.3.4'
)
Expand Down