Run RSpec tests along with minitest #7880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I somehow assumed this was already happening. Will fix the breakage so that this can be merged. |
rolandwalker
added a commit
to rolandwalker/homebrew-cask
that referenced
this pull request
Dec 9, 2014
Return the current value whenever the stanza method is called without arguments, including when the stanza has no value. Do not attempt to construct an instance with no arguments (which typically throws an exception). Incidental comment re: depends_on Refs Homebrew#7880
|
Should be good now if you rebase. |
|
Rebased, works well, thanks for fixing it! :) |
rolandwalker
added a commit
that referenced
this pull request
Dec 10, 2014
Run RSpec tests along with minitest
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the idea of gradually rewriting tests to rspec, but we should also make sure to keep the new tests green and this change should help everyone to do so.
In fact this change made ~1 month ago already caused 4 rspec tests to fail and apparently nobody noticed.
cc @phinze @rolandwalker