Be more consistent/liberal about stanza accessors. #7935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
added
the
core
rolandwalker
changed the title
Return the current value whenever the stanza method is called without arguments, including when the stanza has no value. Do not attempt to construct an instance with no arguments (which typically throws an exception). Incidental comment re: depends_on Refs Homebrew#7880
rolandwalker
force-pushed
the
stanza_accessors
branch
from
8498130 to
2e2023b
Compare
rolandwalker
changed the title
rolandwalker
added a commit
that referenced
this pull request
Dec 9, 2014
Be more consistent/liberal about stanza accessors.
miccal
removed
the
core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the current value whenever a stanza method is called without arguments, including when the stanza has no value. Do not attempt to construct an instance with no arguments (which typically throws an exception).
Incidental comment re:
depends_on.Refs #7880 (this PR allows RSpec to pass)