Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fb303 fbthrift fizz folly wangle watchman 2022.07.04.00 #105079

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added long build Set a long timeout for formula testing CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 4, 2022
@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 5, 2022
@carlocab
Copy link
Member

carlocab commented Jul 5, 2022

May want to wait for #105132. Or roll up the two.

@cho-m cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 5, 2022
@cho-m
Copy link
Member

cho-m commented Jul 6, 2022

May want to wait for #105132. Or roll up the two.

It looks like fmt major update (v8 --> v9) is going to take some more time given build failures. At least a day or so if we rerun with a fmt@8 (should fall into long timeout queue given these formulae). Probably a bit longer if we want to avoid versioned formula and instead try to fix.

Rather than getting blocked on that and given weekly cadence here, it may be better to just get this release out and try to finish fmt PR before next set of these formulae bumps.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@chenrui333 chenrui333 deleted the fb303-fbthrift-fizz-folly-wangle-watchman-2022.07.04.00 branch December 18, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants