Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt 9.0.0 #105132

Closed
wants to merge 28 commits into from
Closed

fmt 9.0.0 #105132

wants to merge 28 commits into from

Conversation

owine
Copy link
Contributor

@owine owine commented Jul 5, 2022

Created by brew bump


Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jul 5, 2022
SMillerDev
SMillerDev previously approved these changes Jul 5, 2022
@carlocab
Copy link
Member

carlocab commented Jul 5, 2022

Error: 33 failed steps!
brew linkage --test bear
brew test --retry --verbose bear
brew linkage --test cherrytree
brew test --retry --verbose cherrytree
brew linkage --test clip
brew test --retry --verbose clip
brew linkage --test easyrpg-player
brew test --retry --verbose easyrpg-player
brew linkage --test fb303
brew test --retry --verbose fb303
brew linkage --test fbthrift
brew test --retry --verbose fbthrift
brew linkage --test fizz
brew test --retry --verbose fizz
brew linkage --test folly
brew test --retry --verbose folly
brew linkage --test gnuradio
brew test --retry --verbose gnuradio
brew linkage --test mkvtoolnix
brew test --retry --verbose mkvtoolnix
brew linkage --test mpd
brew test --retry --verbose mpd
brew linkage --test poac
brew test --retry --verbose poac
brew test --retry --verbose sophus
brew linkage --test spdlog
brew linkage --test vcpkg
brew test --retry --verbose vcpkg
brew linkage --test vowpal-wabbit
brew test --retry --verbose vowpal-wabbit
brew linkage --test wangle
brew linkage --test watchman
brew test --retry --verbose watchman

Let's start by rev bumping the linkage failures:

bear
cherrytree
clip
easyrpg-player
fb303
fbthrift
fizz
folly
gnuradio
mkvtoolnix
mpd
poac
spdlog
vcpkg
vowpal-wabbit
wangle
watchman

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 8, 2022
@carlocab carlocab added help wanted Task(s) needing PRs from the community or maintainers and removed stale No recent activity labels Jul 8, 2022
@cho-m cho-m mentioned this pull request Jul 11, 2022
@owine
Copy link
Contributor Author

owine commented Jul 14, 2022

bear needs an upstream fix

rizsotto/Bear#471

@carlocab
Copy link
Member

So do gnuradio, mpd, poac, vcpkg, and vowpal-wabbit.

@carlocab
Copy link
Member

carlocab commented Jul 20, 2022

Upstream issue for vcpkg: microsoft/vcpkg#25673

Unsure if gnuradio has fixed this. Some possibly related PRs: gnuradio/gnuradio#5990, gnuradio/gnuradio#5935

mpd is fixed in MusicPlayerDaemon/MPD@1387380. Fix is in the 0.23.8 tag, but the version bump stalled at #105425.

poac: cabinpkg/cabin#653

vowpal-wabbit: VowpalWabbit/vowpal_wabbit#4058

sophus might also need looking at.

@carlocab
Copy link
Member

carlocab commented Jul 21, 2022

poac fixed by recent version bump here.

vowpal-wabbit fixed in VowpalWabbit/vowpal_wabbit#4059

vcpkg fixed in microsoft/vcpkg-tool#634

bear seems to be fixed by rizsotto/Bear@e10184e, rizsotto/Bear@e92ea46, rizsotto/Bear@67d5a34, but they will cut a new release this week: rizsotto/Bear#471

I think the only unclear cases are gnuradio and sophus.

@carlocab carlocab mentioned this pull request Jul 21, 2022
@owine
Copy link
Contributor Author

owine commented Jul 24, 2022

#106462 for bear with fix merged
#106463 for vcpkg but does not appear to have the fix merged - awaiting a new release of fmt

@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 24, 2022
@carlocab
Copy link
Member

Tried to apply the patch from gnuradio/gnuradio#5935, but it failed, unfortunately.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jul 24, 2022
We might be able to avoid Sophus using `fmt` by setting
`SOPHUS_USE_BASIC_LOGGING`.

Needed for Homebrew#105132.
@cho-m cho-m added the long build Set a long timeout for formula testing label Jul 24, 2022
@danielnachun danielnachun removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 25, 2022
@cho-m
Copy link
Member

cho-m commented Aug 15, 2022

gnuradio now has open PR gnuradio/gnuradio#6053

carlocab and others added 9 commits August 16, 2022 23:59
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
carlocab
carlocab previously approved these changes Aug 16, 2022
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove the revision bumps when cherry-picking the FB formulae.

carlocab
carlocab previously approved these changes Aug 16, 2022
@carlocab carlocab added the CI-linux-self-hosted Build on Linux self-hosted runner label Aug 16, 2022
@carlocab
Copy link
Member

All bottles built on Linux except for Watchman, which got killed by the timeout. I'll trigger that separately, since this has waited long enough.

@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 17, 2022
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @carlocab bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review August 17, 2022 00:02

bottle publish failed

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@owine owine deleted the bump-fmt-9.0.0 branch August 17, 2022 00:19
@carlocab carlocab mentioned this pull request Aug 19, 2022
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing no long build conflict Do not allow merging other pull requests when files conflict with this one outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants