Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fmt to version 9.0.0 #634

Closed
wants to merge 2 commits into from
Closed

Updated fmt to version 9.0.0 #634

wants to merge 2 commits into from

Conversation

xvitaly
Copy link
Contributor

@xvitaly xvitaly commented Jul 16, 2022

  • Fixed build against packaged fmt 9.0.0.
  • Updated bundled fmt to version 9.0.0.
  • Performed refactoring of Findfmt.cmake.

Closes microsoft/vcpkg#25673

Signed-off-by: Vitaly Zaitsev <vitaly@easycoding.org>
Signed-off-by: Vitaly Zaitsev <vitaly@easycoding.org>
@xvitaly
Copy link
Contributor Author

xvitaly commented Jul 16, 2022

Reported Windows build failure to fmt upstream.

@xvitaly xvitaly changed the title Fixed build against fmt 9.0.0 Updated fmt to version 9.0.0 Jul 16, 2022
@xvitaly
Copy link
Contributor Author

xvitaly commented Jul 16, 2022

Should be fixed in 9.0.1.

@BillyONeal BillyONeal added the depends:different-pr This PR depends on a different PR which has been filed label Jul 18, 2022
@BillyONeal
Copy link
Member

Hi there! Because as you've seen this breaks things, I don't think we're going to take this, so I'm going to close this PR for now. We welcome a new PR once 9.0.1 comes out with a fix!

Thanks!

@xvitaly
Copy link
Contributor Author

xvitaly commented Aug 27, 2022

Because as you've seen this breaks things, I don't think we're going to take this, so I'm going to close this PR for now. We welcome a new PR once 9.0.1 comes out with a fix!

Fixed in #679. All tests passed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends:different-pr This PR depends on a different PR which has been filed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vcpkg] build failure against fmt 9.0.0
2 participants