Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryfs: revision bump (fmt 9.0.0) #108414

Closed
wants to merge 1 commit into from
Closed

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Missed from #105132.

@BrewTestBot BrewTestBot added boost Boost use is a significant feature of the PR or issue deprecated license Formula uses a deprecated SPDX license which should be updated python Python use is a significant feature of the PR or issue labels Aug 19, 2022
@cho-m
Copy link
Member

cho-m commented Aug 19, 2022

Can try cryfs/cryfs#433

Comment on lines +60 to +61
ENV.prepend_path "PYTHONPATH", venv_root/Language::Python.site_packages(python)
ENV.prepend_path "PATH", venv_root/"bin"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why PYTHONPATH is needed, since any python used will be the one in the venv.

@carlocab carlocab added the ready to merge PR can be merged once CI is green label Aug 19, 2022
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab carlocab deleted the cryfs-fmt branch August 21, 2022 12:35
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
boost Boost use is a significant feature of the PR or issue deprecated license Formula uses a deprecated SPDX license which should be updated outdated PR was locked due to age python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants