Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtorch: fix python3 reference. #110116

Merged
merged 4 commits into from
Oct 6, 2022
Merged

libtorch: fix python3 reference. #110116

merged 4 commits into from
Oct 6, 2022

Conversation

miles170
Copy link
Contributor

@miles170 miles170 commented Sep 9, 2022 •
edited
Loading

See #110462.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Sep 9, 2022
@miles170 miles170 mentioned this pull request Sep 13, 2022
Closed
50 tasks
@iMichka iMichka added the long build Set a long timeout for formula testing label Sep 14, 2022
@cho-m cho-m added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Sep 14, 2022
@miles170
Copy link
Contributor Author

miles170 commented Oct 2, 2022 •
edited
Loading

Rerun CI tests with Python 3.10.7 (#109777).

@miles170
Copy link
Contributor Author

miles170 commented Oct 2, 2022

@carlocab Could you help with either removing the long build label or adding the CI-long-timeout label?

@carlocab carlocab added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed long build Set a long timeout for formula testing labels Oct 2, 2022
@miles170
Copy link
Contributor Author

miles170 commented Oct 2, 2022

It seems that PyTorch fails to build on Intel Mac (pytorch/pytorch#85956).

@iMichka iMichka added the long build Set a long timeout for formula testing label Oct 2, 2022
@miles170
Copy link
Contributor Author

miles170 commented Oct 3, 2022 •
edited
Loading

Should this pull request be cherry-picked into #111889?

@iMichka
Copy link
Member

iMichka commented Oct 3, 2022

Done. We need a long build slot to test again.

@miles170
Copy link
Contributor Author

miles170 commented Oct 4, 2022

@cho-m Could you help with adding CI-long-timeout label to test the new patch?

@iMichka iMichka added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 4, 2022
@danielnachun
Copy link
Member

We might also want to have this depend on pyyaml and drop the PyYAML dependency as done in #111889.

@danielnachun danielnachun removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. long build Set a long timeout for formula testing labels Oct 4, 2022
@danielnachun
Copy link
Member

I'm turning off long build temporarily to make sure this works for the first 90 minutes. That will help to avoid wasting a long timeout run.

@danielnachun danielnachun force-pushed the libtorch branch 3 times, most recently from b06d5bf to 9eca6b7 Compare October 5, 2022 05:35
@danielnachun
Copy link
Member

danielnachun commented Oct 5, 2022 •
edited
Loading

Now I see what the problem is - we need grab the newer version of fbgemm as a resource using the commit hash in that patch.

@danielnachun danielnachun added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. long build Set a long timeout for formula testing labels Oct 5, 2022
@danielnachun
Copy link
Member

Everything worked in the local build I ran on my Intel Mac so I'm hoping we'll have a successful run here now.

@cho-m cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 5, 2022
@danielnachun
Copy link
Member

@carlocab I think these changes are still compatible with CI-no-bottles. If so we should be able to get this merged.

@danielnachun danielnachun added the ready to merge PR can be merged once CI is green label Oct 6, 2022
This was referenced Oct 6, 2022
Closed
Closed
danielnachun
danielnachun approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@danielnachun danielnachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No opposition to this has been raised so I am going to approve and merge this.

@danielnachun danielnachun merged commit f1af34b into Homebrew:master Oct 6, 2022
@miles170 miles170 deleted the libtorch branch October 7, 2022 02:41
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielnachun danielnachun danielnachun approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miles170 @iMichka @danielnachun @cho-m @carlocab