Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtorch: fix python3 reference. #110116

Merged
merged 4 commits into from
Oct 6, 2022
Merged

libtorch: fix python3 reference. #110116

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b080e5e
libtorch: fix `python3` reference.
miles170 Sep 9, 2022
e28ac19
libtorch: add patch for build on macOS
iMichka Oct 2, 2022
d5a780d
libtorch: fix patch and remove unneeded deps
danielnachun Oct 5, 2022
6c28f75
libtorch: replace patch, fix python path and cmake
danielnachun Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 16 additions & 20 deletions Formula/libtorch.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
class Libtorch < Formula
include Language::Python::Virtualenv

desc "Tensors and dynamic neural networks"
homepage "https://pytorch.org/"
url "https://github.com/pytorch/pytorch.git",
Expand Down Expand Up @@ -28,29 +26,28 @@ class Libtorch < Formula
depends_on "libyaml"
depends_on "protobuf"
depends_on "pybind11"
depends_on "python-typing-extensions"
depends_on "pyyaml"

on_macos do
depends_on "libomp"
end

resource "PyYAML" do
url "https://files.pythonhosted.org/packages/36/2b/61d51a2c4f25ef062ae3f74576b01638bebad5e045f747ff12643df63844/PyYAML-6.0.tar.gz"
sha256 "68fb519c14306fec9720a2a5b45bc9f0c8d1b9c72adf45c37baedfcd949c35a2"
end

resource "typing-extensions" do
url "https://files.pythonhosted.org/packages/9e/1d/d128169ff58c501059330f1ad96ed62b79114a2eb30b8238af63a2e27f70/typing_extensions-4.3.0.tar.gz"
sha256 "e6d2677a32f47fc7eb2795db1dd15c1f34eff616bcaf2cfb5e997f854fa1c4a6"
# Update fbgemm to a version that works with macOS on Intel.
# Remove with next release.
resource "fbgemm" do
url "https://github.com/pytorch/FBGEMM.git",
revision: "0d98c261561524cce92e37fe307ea6596664309a"
end

def install
venv = virtualenv_create(buildpath/"venv", Formula["python@3.10"].opt_bin/"python3")
venv.pip_install resources
rm_r "third_party/fbgemm"

resource("fbgemm").stage(buildpath/"third_party/fbgemm")

args = %W[
args = %w[
-DBUILD_CUSTOM_PROTOBUF=OFF
-DBUILD_PYTHON=OFF
-DPYTHON_EXECUTABLE=#{buildpath}/venv/bin/python
-DUSE_CUDA=OFF
-DUSE_METAL=OFF
-DUSE_MKLDNN=OFF
Expand All @@ -62,14 +59,13 @@ def install
# Remove when https://github.com/pytorch/pytorch/issues/67974 is addressed
args << "-DUSE_SYSTEM_BIND11=ON"

mkdir "build" do
system "cmake", "..", *std_cmake_args, *args
system "cmake", "-B", "build", "-S", ".", *std_cmake_args, *args

# Avoid references to Homebrew shims
inreplace "caffe2/core/macros.h", Superenv.shims_path/ENV.cxx, ENV.cxx
# Avoid references to Homebrew shims
inreplace "build/caffe2/core/macros.h", Superenv.shims_path/ENV.cxx, ENV.cxx

system "cmake", "--build", ".", "--target", "install"
end
system "cmake", "--build", "build"
system "cmake", "--install", "build"
end

test do
Expand Down