Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudflared: build with go1.20 #136864

Merged
merged 2 commits into from
Jul 18, 2023
Merged

cloudflared: build with go1.20 #136864

merged 2 commits into from
Jul 18, 2023

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Jul 18, 2023 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue autosquash Automatically squash pull request commits according to Homebrew style. labels Jul 18, 2023
@stefanb stefanb marked this pull request as ready for review July 18, 2023 03:13
@stefanb stefanb changed the title cloudflared (go dep bump) cloudflared 2023.7.1 (go dep bump) Jul 18, 2023
@stefanb stefanb changed the title cloudflared 2023.7.1 (go dep bump) cloudflared 2023.7.1 (unpin go dependancy) Jul 18, 2023
@stefanb @chenrui333
cloudflared: build with go1.20
6d579f6 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 18, 2023
@chenrui333 chenrui333 changed the title cloudflared 2023.7.1 (unpin go dependancy) cloudflared: build with go1.20 Jul 18, 2023
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jul 18, 2023
@chenrui333
Copy link
Member

make sense, thanks @stefanb!

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 18, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 18, 2023
Merged via the queue into Homebrew:master with commit 5726c3f Jul 18, 2023
12 checks passed
@stefanb stefanb deleted the cloudflared-go branch July 18, 2023 05:03
@stefanb stefanb mentioned this pull request Aug 3, 2023
Merged
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@carlocab carlocab carlocab approved these changes

@github-actions GitHub Actions github-actions approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefanb @chenrui333 @carlocab @BrewTestBot