Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBFS due to quic-go not supporting go 1.20 #888

Closed
grawlinson opened this issue Feb 4, 2023 · 11 comments
Closed

FTBFS due to quic-go not supporting go 1.20 #888

grawlinson opened this issue Feb 4, 2023 · 11 comments
Labels
Confirmed Issue has been reproduced and confirmed Priority: Normal Minor issue impacting one or more users Type: Bug Something isn't working

Comments

@grawlinson
Copy link

Describe the bug
cloudflared does not compile on go 1.20 due to the quic-go dependency specified in go.mod not supporting 1.20.

As of ~13 hours ago, 1.20 is supported upstream.

To Reproduce
Compile with go 1.20 and it will fail with the following error:

# github.com/lucas-clemente/quic-go/internal/qtls
../pkg/mod/github.com/chungthuang/quic-go@v0.27.1-0.20220809135021-ca330f1dec9f/internal/qtls/go120.go:6:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet. For more details, please see https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.20 yet. F...) as int value in variable declarat

The dependency on quic-go should probably be updated sooner rather than later.

@grawlinson grawlinson added Priority: Normal Minor issue impacting one or more users Type: Bug Something isn't working labels Feb 4, 2023
@sudarshan-reddy sudarshan-reddy self-assigned this Feb 4, 2023
@sudarshan-reddy
Copy link
Contributor

Thanks for flagging this @grawlinson

@mraerino
Copy link

this is going to be extra tricky, since cloudflared does not use upstream quic-go, but a fork.
would you accept a PR that changed to using the latest upstream quic-go release?

@sudarshan-reddy
Copy link
Contributor

@mraerino : There's work being done on this. I'll tag in @bwesterb here.

@bwesterb
Copy link
Member

We actually do use upstream quic-go, but replace the underlying qtls library. I prepared one for 1.20 yesterday, so it's ready to go.

@bwesterb bwesterb removed their assignment Feb 16, 2023
@b0gdanw
Copy link

b0gdanw commented Mar 14, 2023

cloudflared-2023.3.1
go version go1.20.2 darwin/arm64

github.com/lucas-clemente/quic-go/internal/qtls
vendor/github.com/lucas-clemente/quic-go/internal/qtls/go120.go:6:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet. For more details, please see https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.20 yet. F...) as int value in variable declaration

@1715173329
Copy link

any update?

@stefanb
Copy link

stefanb commented Jun 22, 2023

FYI, go 1.21 will be released soon (see rc2 announcement), which will make go 1.19 not maintained anymore.

@AndrewBucklin
Copy link

What’s the latest on this?

@b0gdanw
Copy link

b0gdanw commented Jul 17, 2023

Successfully built cloudflared 2023.7.1 from source with go version go1.20.6 darwin/arm64

@i0ntempest
Copy link

Same as above on x86_64

@stefanb
Copy link

stefanb commented Jul 18, 2023

Seems that it was already fixed in 2023.5.1 via TUN-7227: Migrate to devincarr/quic-go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Issue has been reproduced and confirmed Priority: Normal Minor issue impacting one or more users Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants