Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/cloudflared(FTBFS): force bump quic-go on go1.20 #698

Closed
mochaaP opened this issue Apr 17, 2023 · 5 comments
Closed

net/cloudflared(FTBFS): force bump quic-go on go1.20 #698

mochaaP opened this issue Apr 17, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@mochaaP
Copy link
Contributor

mochaaP commented Apr 17, 2023

https://github.com/immortalwrt/packages/actions/runs/4725339224/jobs/8383627775#step:5:4318 due to a outdated dependency (maybe plus some incorrect module replaces), the package could not build with go1.20 on the master branch.

Solution

a). Patch go.mod ourselves for now
b). Ask upstream about bumping deps
@1715173329
Copy link
Member

b). Ask upstream about bumping deps

Unfortunately we got no response from upstream.
See cloudflare/cloudflared#888

@mochaaP
Copy link
Contributor Author

mochaaP commented Apr 17, 2023

Bumping deps and testing on my local machine. Will submit a pull request to upstream if it works.

@mochaaP
Copy link
Contributor Author

mochaaP commented Apr 17, 2023

PR is live at cloudflare/cloudflared#945. reviews are welcomed.

1715173329 added a commit that referenced this issue Apr 18, 2023
@1715173329
cloudflared: backport a fix for go 1.20
4682bae 
Ref: #698

Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
@1715173329 1715173329 added the bug Something isn't working label Apr 18, 2023
@mochaaP mochaaP changed the title net/cloudflared(FTBTS): force bump quic-go on go1.20 net/cloudflared(FTBFS): force bump quic-go on go1.20 Apr 28, 2023
@1715173329
Copy link
Member

it somehow compiles again in 2023.5.1.

@stefanb
Copy link

stefanb commented Jul 18, 2023

"somehow" -> due to cloudflare/cloudflared@9426b60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanb @mochaaP @1715173329