Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gspell: depend on Python for build #154128

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Nov 13, 2023

Since #152017, glib does not provide Python as a dependency anymore. gspell fails to build as it does not find Python

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Since Homebrew#152017, glib does not provide Python as a dependency anymore.
gspell fails to build as it does not find Python
@iMichka iMichka added the CI-no-bottles Merge without publishing bottles label Nov 13, 2023
@github-actions github-actions bot added the icu4c ICU use is a significant feature of the PR or issue label Nov 13, 2023
@iMichka iMichka mentioned this pull request Nov 13, 2023
6 tasks
@cho-m
Copy link
Member

cho-m commented Nov 13, 2023

Is this for Linux or also for macOS?

We originally just used system/devtools Python on macOS. We really should restore uses_from_macos "python", since: :catalina for Linux in glib which was removed in f3674b1 since we install scripts that have shebang of /usr/bin/env python3:

rewrite_shebang detected_python_shebang(use_python_from_path: true), *bin.children

@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 13, 2023
Merged via the queue into Homebrew:master with commit e5f87bd Nov 13, 2023
26 checks passed
@iMichka iMichka deleted the gpsell branch November 13, 2023 21:47
iMichka added a commit to iMichka/homebrew-core that referenced this pull request Nov 13, 2023
Reverts Homebrew#154128
I added Python back as a glib dependency in the previous commit
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles icu4c ICU use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants