Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icu4c 74.2 #153108

Merged
merged 130 commits into from
Feb 25, 2024
Merged

icu4c 74.2 #153108

merged 130 commits into from
Feb 25, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@p-linnane p-linnane added CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels Nov 1, 2023
@chenrui333 chenrui333 mentioned this pull request Nov 1, 2023
6 tasks
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 1, 2023
@p-linnane p-linnane added in progress Stale bot should stay away CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Nov 1, 2023
@Bo98
Copy link
Member

Bo98 commented Nov 6, 2023

Promising initial run.

Linux:

  • gspell can't seem to find python3 (via glib I think).
  • manticoresearch sha256 error.
  • planck fails because it looks like webkitgtk needs a revision bump.
  • qt (Chromium) is incompatible with ICU 74 due to the addition of five new line break types with Unicode 15.1. There'll probably be a patch soon, if not already. If it hasn't by the time we've fixed everything else here, we can patch ourselves e.g.:
#if U_ICU_VERSION_MAJOR_NUM >= 74
#define BA_LB_COUNT (U_LB_COUNT - 8)
...
  • simdutf timed out for some reason - might need a lighter test or maybe it's signalling a genuine problem.
  • tepl also can't find python3 (via glib too I think)
  • vte3 also can't find python3 - I reckon there's something wrong with glib and we'll need to fix that before proceeding here.
  • zobra maybe segfaulting

macOS:

  • manticoresearch sha256 error.
  • texlive - Perl mismatch somewhere: Parser.c: loadable library and perl binaries are mismatched (got first handshake key 0x10380080, needed 0x10200080)

Any non-disabled PHP versioned formula also needs revision bumping here: php@8.1 and php@8.0.

(Haven't checked dependent tests yet as they're still running)

@Porkepix
Copy link
Contributor

Porkepix commented Nov 6, 2023

Any non-disabled PHP versioned formula also needs revision bumping here: php@8.1 and php@8.0.

Note that active support for php@8.0 is already gone, and security support will also be on 26th of November. Dunno if it calls for immediate deprecation/disabling, but it might save some time on it depending on when this PR is finalized.

@Bo98
Copy link
Member

Bo98 commented Nov 6, 2023

It'll probably just be a case of we'll do it if this PR ships before that date, and not if it doesn't. PHP's light enough to only take 10-20 minutes to build.

Focus first is fixing the other things though.

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 6, 2023
@iMichka
Copy link
Member

iMichka commented Nov 13, 2023

Fix for gspell: #154128

@p-linnane p-linnane added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 26, 2023
@Bo98
Copy link
Member

Bo98 commented Nov 26, 2023

Looks like none of the PHP formulae are being revision bumped here. 8.0 isn't a concern anymore but anything newer, including the latest, is.

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 28, 2023
@iMichka
Copy link
Member

iMichka commented Nov 29, 2023

Linux failures:

2023-11-26T22:49:55.1656031Z Warning: 2 failed steps ignored!
2023-11-26T22:49:55.1658020Z brew test --verbose simdutf
2023-11-26T22:49:55.1658927Z brew install --verbose --build-bottle zorba
2023-11-26T22:49:55.1666147Z Error: 3 failed steps!
2023-11-26T22:49:55.1666866Z brew test --verbose yaz
2023-11-26T22:49:55.1667427Z brew install --verbose --build-bottle planck
2023-11-26T22:49:55.1668176Z brew install --verbose --build-bottle qt

@cho-m
Copy link
Member

cho-m commented Nov 30, 2023

Ignoring missing revision bumps and failures I already fixed in referenced PRs, the main failures are:

  • qt - another libxml2 issue. Sadly 2.12 introduced a fair amount of breakage. Probably should try to fix outside this PR either in qt 6.6.1 #155921 or a separate PR. I think issue is fixed upstream of upstream (Chromium) but haven't checked what version newer qt is using.
  • texlive - still the Perl mismatch issue when building HTML::TreeBuilder (with mismatch coming from previous resource HTML::Parser which is dependency?). I see we have a separate PR to work on this texlive: add Test::Fatal dependency and rebuild #155568.

Outside those, the rest look like flaky dependent tests or other unrelated issues:

@cho-m
Copy link
Member

cho-m commented Dec 1, 2023

Added some extra revision bumps.

Dealing with patches for qt in separate PR #156065.

Will need another rebase before running.

@p-linnane p-linnane added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 2, 2023
@cho-m
Copy link
Member

cho-m commented Dec 3, 2023

Linux failed to build webkitgtk, planck (due to webkitgtk) , and swift:

  • webkitgtk - another libxml2 issue - WebKit/WebKit@1bad176 - webkitgtk 2.42.3 #156786
    2023-12-03T00:43:41.6692807Z /tmp/webkitgtk-20231202-188180-corvlx/webkitgtk-2.40.5/Source/WebCore/xml/XSLStyleSheetLibxslt.cpp:143:106: error: invalid conversion from ‘void (*)(void*, xmlError*)’ {aka ‘void (*)(void*, _xmlError*)’} to ‘xmlStructuredErrorFunc’ {aka ‘void (*)(void*, const _xmlError*)’} [-fpermissive]
    2023-12-03T00:43:41.6695985Z   143 |     XMLDocumentParserScope scope(cachedResourceLoader(), XSLTProcessor::genericErrorFunc, XSLTProcessor::parseErrorFunc, console);
    2023-12-03T00:43:41.6697143Z       |                                                                                           ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
    2023-12-03T00:43:41.6697780Z       |                                                                                                          |
    2023-12-03T00:43:41.6698650Z       |                                                                                                          void (*)(void*, xmlError*) {aka void (*)(void*, _xmlError*)}
    
  • swift - it's accidentally picking up python@3.12 from a dependency and failing without python-setuptools. We should use an argument to make sure the Python matches dependency we set:
    2023-12-03T17:53:20.9369231Z FAILED: lib/libc++.a 
    2023-12-03T17:53:20.9392590Z : && /home/linuxbrew/.linuxbrew/Cellar/cmake/3.27.9/bin/cmake -E rm -f lib/libc++.a && /tmp/swift-20231203-1836061-etto1i/build/llvm-linux-x86_64/bin/llvm-ar Dqc lib/libc++.a  libcxx/src/CMakeFiles/cxx_static.dir/algorithm.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/any.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/assert.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/atomic.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/barrier.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/bind.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/charconv.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/chrono.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/condition_variable.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/condition_variable_destructor.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/exception.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/functional.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/future.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/hash.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/legacy_pointer_safety.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/memory.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/mutex.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/mutex_destructor.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/new.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/optional.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/random_shuffle.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/ryu/d2fixed.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/ryu/d2s.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/ryu/f2s.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/shared_mutex.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/stdexcept.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/string.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/system_error.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/thread.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/typeinfo.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/utility.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/valarray.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/variant.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/vector.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/debug.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/legacy_debug_handler.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/random.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/ios.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/ios.instantiations.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/iostream.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/locale.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/regex.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/strstream.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/format.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/filesystem/operations.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/filesystem/directory_iterator.cpp.o libcxx/src/CMakeFiles/cxx_static.dir/filesystem/int128_builtins.cpp.o && /tmp/swift-20231203-1836061-etto1i/build/llvm-linux-x86_64/bin/llvm-ranlib -D lib/libc++.a && cd /tmp/swift-20231203-1836061-etto1i/build/llvm-linux-x86_64/tools/clang/runtime/compiler-rt-bins/lib/fuzzer/libcxx_fuzzer_x86_64/libcxx/src && /home/linuxbrew/.linuxbrew/bin/python3.12 /tmp/swift-20231203-1836061-etto1i/llvm-project/libcxx/utils/merge_archives.py -o /tmp/swift-20231203-1836061-etto1i/build/llvm-linux-x86_64/tools/clang/runtime/compiler-rt-bins/lib/fuzzer/libcxx_fuzzer_x86_64/lib/libc++.a --ar /tmp/swift-20231203-1836061-etto1i/build/llvm-linux-x86_64/bin/llvm-ar /tmp/swift-20231203-1836061-etto1i/build/llvm-linux-x86_64/tools/clang/runtime/compiler-rt-bins/lib/fuzzer/libcxx_fuzzer_x86_64/lib/libc++.a /tmp/swift-20231203-1836061-etto1i/build/llvm-linux-x86_64/tools/clang/runtime/compiler-rt-bins/lib/fuzzer/libcxx_fuzzer_x86_64/lib/libc++abi.a
    2023-12-03T17:53:20.9392949Z Traceback (most recent call last):
    2023-12-03T17:53:20.9393908Z   File "/tmp/swift-20231203-1836061-etto1i/llvm-project/libcxx/utils/merge_archives.py", line 11, in <module>
    2023-12-03T17:53:20.9394097Z     import distutils.spawn
    2023-12-03T17:53:20.9394458Z ModuleNotFoundError: No module named 'distutils'
    

@p-linnane p-linnane mentioned this pull request Dec 4, 2023
6 tasks
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 5, 2023
@Porkepix
Copy link
Contributor

74.2 is out.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 25, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 25, 2024
Merged via the queue into Homebrew:master with commit 7758d39 Feb 25, 2024
12 checks passed
@p-linnane p-linnane deleted the bump-icu4c-74.1 branch February 25, 2024 06:00
@p-linnane
Copy link
Member Author

Thanks to everyone who contributed to the effort to get this version bump merged!

@chenrui333
Copy link
Member

chenrui333 commented Feb 25, 2024

Awesome work! 💯

@p-linnane p-linnane mentioned this pull request Feb 26, 2024
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-bottle-cache Disable bottle cache CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away large-bottle-upload [DEPRECATED] Pull request requires a large runner to upload bottles long build Set a long timeout for formula testing no long build conflict Do not allow merging other pull requests when files conflict with this one outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.