Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcb2gcode: update dependencies #156354

Merged
merged 2 commits into from
Dec 4, 2023
Merged

pcb2gcode: update dependencies #156354

merged 2 commits into from
Dec 4, 2023

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This fixes a bunch of indirect dependencies with linkage as seen in failing linkage checks in #153108.

@p-linnane p-linnane added the CI-no-bottles Merge without publishing bottles label Dec 4, 2023
@github-actions github-actions bot added the boost Boost use is a significant feature of the PR or issue label Dec 4, 2023
@chenrui333
Copy link
Member

considering the dependency change, we need to do the re-bottle for this PR?

@p-linnane
Copy link
Member Author

Yeah good point.

@p-linnane p-linnane removed the CI-no-bottles Merge without publishing bottles label Dec 4, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 4, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 4, 2023
Merged via the queue into Homebrew:master with commit b8e21b4 Dec 4, 2023
12 checks passed
@p-linnane p-linnane deleted the pcb2gcode-deps branch December 4, 2023 20:02
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
boost Boost use is a significant feature of the PR or issue CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants