Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hadoop solr@8.11: increase test sleep #156049

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 30, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Let's try increasing both these sleep times to see if they help in #153108.

I think it will help for hadoop as the failed logs look like it wasn't fully ready.

solr@8.11 is a mystery as we don't output/save the logs. It is hard to reproduce in isolation so just increasing sleep and hoping for the best. If it keeps failing, then can rewrite the test to run in foreground.

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Nov 30, 2023
@github-actions github-actions bot added the java Java use is a significant feature of the PR or issue label Nov 30, 2023
@cho-m cho-m mentioned this pull request Nov 30, 2023
6 tasks
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 30, 2023
Merged via the queue into Homebrew:master with commit faa385c Nov 30, 2023
27 checks passed
@iMichka iMichka mentioned this pull request Dec 6, 2023
6 tasks
iMichka added a commit to iMichka/homebrew-core that referenced this pull request Dec 7, 2023
This test is often failing. We already tried to fix it in Homebrew#156049

Found in Homebrew#156470

Looking at the analytics, I think this is the quickest solution:
install: 59 (30 days), 226 (90 days), 403 (365 days)
install-on-request: 59 (30 days), 226 (90 days), 403 (365 days)
build-error: 0 (30 days)
@cho-m cho-m deleted the hadoop-solr-sleep branch December 10, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles java Java use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants