Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlive: add Test::Fatal dependency and rebuild #155568

Closed
wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

relates to #153108


  ==> perl Build.PL --install_base /opt/homebrew/Cellar/texlive/20230313_3/libexec
  Checking prerequisites...
    build_requires:
      !  Test::Fatal is not installed
    recommends:
      *  HTML::FormatText is not installed
      *  LWP::UserAgent is not installed

     HTML::FormatText is only required if you want to use HTML::Element's
     "format" method, which converts HTML to formatted plain text.

     LWP::UserAgent is only required if you want to use HTML::TreeBuilder's
     "new_from_url" method, which fetches a document given its URL.

     If you install these modules later, you do NOT need to reinstall HTML-Tree.

  ERRORS/WARNINGS FOUND IN PREREQUISITES.  You may wish to install the versions
  of the modules indicated above before proceeding with this installation

  Run 'Build installdeps' to install missing prerequisites.

  Created MYMETA.yml and MYMETA.json
  Creating new 'Build' script for 'HTML-Tree' version '5.07'
  ==> ./Build
  Parser.c: loadable library and perl binaries are mismatched (got first handshake key 0x10380080, needed 0x10200080)

seeing in https://github.com/Homebrew/homebrew-core/actions/runs/6993254295/job/19025754067?pr=153108

@github-actions github-actions bot added lua Lua use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue perl Perl use is a significant feature of the PR or issue long build Set a long timeout for formula testing large-bottle-upload [DEPRECATED] Pull request requires a large runner to upload bottles labels Nov 26, 2023
@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed long build Set a long timeout for formula testing labels Nov 26, 2023
@fxcoudert
Copy link
Member

Bumping revision means we force all users to redownload the huge bottle (what is it? 1GB?). Do we actually want that, or just to dispatch a rebuild of the bottles through the workflow?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. long build Set a long timeout for formula testing labels Nov 28, 2023
@iMichka iMichka added the CI-linux-self-hosted Build on Linux self-hosted runner label Nov 29, 2023
```
  ==> perl Build.PL --install_base /opt/homebrew/Cellar/texlive/20230313_3/libexec
  Checking prerequisites...
    build_requires:
      !  Test::Fatal is not installed
    recommends:
      *  HTML::FormatText is not installed
      *  LWP::UserAgent is not installed

     HTML::FormatText is only required if you want to use HTML::Element's
     "format" method, which converts HTML to formatted plain text.

     LWP::UserAgent is only required if you want to use HTML::TreeBuilder's
     "new_from_url" method, which fetches a document given its URL.

     If you install these modules later, you do NOT need to reinstall HTML-Tree.

  ERRORS/WARNINGS FOUND IN PREREQUISITES.  You may wish to install the versions
  of the modules indicated above before proceeding with this installation

  Run 'Build installdeps' to install missing prerequisites.

  Created MYMETA.yml and MYMETA.json
  Creating new 'Build' script for 'HTML-Tree' version '5.07'
  ==> ./Build
  Parser.c: loadable library and perl binaries are mismatched (got first handshake key 0x10380080, needed 0x10200080)
```

seeing in https://github.com/Homebrew/homebrew-core/actions/runs/6993254295/job/19025754067?pr=153108

Signed-off-by: Rui Chen <rui@chenrui.dev>
@iMichka iMichka added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 29, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 29, 2023
@iMichka
Copy link
Member

iMichka commented Nov 29, 2023

Let's just add the missing dependency then, that should be enough.

@iMichka iMichka changed the title texlive: rebuild texlive: add Test::Fatal dependency and rebuild Nov 29, 2023
@SMillerDev
Copy link
Member


  Parser.c: loadable library and perl binaries are mismatched (got first handshake key 0x10380080, needed 0x10200080)

@chenrui333
Copy link
Member Author

Bumping revision means we force all users to redownload the huge bottle (what is it? 1GB?). Do we actually want that, or just to dispatch a rebuild of the bottles through the workflow?

I should be more clear that the initial idea is just to trigger the rebuild (if that works, we can just dispatch the bottle rebuild), I did not intend to enforce the revision bump.

@chenrui333 chenrui333 marked this pull request as draft November 29, 2023 21:32
@chenrui333
Copy link
Member Author

also mark the PR to draft mode before we can want to merge it.

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 29, 2023
@cho-m cho-m mentioned this pull request Nov 30, 2023
6 tasks
@cho-m
Copy link
Member

cho-m commented Nov 30, 2023

So far, what I've noticed is:

  • perl 5.36 works
  • perl 5.38 fails building HTML::TreeBuilder complaining on HTML::Parser. It looks like our use of CCFLAGS is causing this.

We may be overriding some default CCFLAGS that are breaking the compatibility between modules.

/opt/homebrew/bin/perl -MConfig -E 'say $Config{ccflags}'
-fno-common -DPERL_DARWIN -mmacosx-version-min=14.0 -DNO_POSIX_2008_LOCALE -fno-strict-aliasing -pipe -fstack-protector-strong/usr/bin/perl -MConfig -E 'say $Config{ccflags}'
 -g -pipe -DPERL_USE_SAFE_PUTENV

@cho-m
Copy link
Member

cho-m commented Nov 30, 2023

Trying out something else in #156019

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2023
@chenrui333 chenrui333 deleted the texlive-rebuild branch January 22, 2024 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. java Java use is a significant feature of the PR or issue large-bottle-upload [DEPRECATED] Pull request requires a large runner to upload bottles long build Set a long timeout for formula testing lua Lua use is a significant feature of the PR or issue outdated PR was locked due to age perl Perl use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants