Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chafa: add support for AVIF and JPEG XL #191925

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

stevenwalton
Copy link
Contributor

Current formula does not support viewing AVIF (AV1) files nor does it support JPEG-XL files.
This is resolved by adding dependencies for libavif and jpeg-xl.

Native AVIF format has been supported since version 1.14.0, wherein ImageMagick was removed. Details in chafa 107 and 157 hpjansson/chafa#107
hpjansson/chafa#157

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 26, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@stevenwalton
Copy link
Contributor Author

  Error: python@3.12: the bottle needs the Apple Command Line Tools to be installed.
    You can install them, if desired, with:
      xcode-select --install

I think the macOS 15 job is improperly configured. FWIW, I'm building from Sequoia.

@carlocab carlocab changed the title Adding support for AVIF and JPEG XL chafa: add support for AVIF and JPEG XL Sep 26, 2024
Current formula does not support viewing AVIF (AV1) files nor does it
support JPEG-XL files.
This is resolved by adding dependencies for libavif and jpeg-xl.

Native AVIF format has been supported since version 1.14.0, wherein
ImageMagick was removed. Details in chafa 107 and 157
hpjansson/chafa#107
hpjansson/chafa#157
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 26, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 26, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 26, 2024
Merged via the queue into Homebrew:master with commit 40d1a6d Sep 26, 2024
15 checks passed
@stevenwalton stevenwalton deleted the stevenwalton branch September 26, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants