Remove ImageMagick support #157
Labels
compatibility
Compatibility (e.g. terminal quirks)
security
Potential security issue
tidiness
Code organization and compliance
Comments
hpjansson
added
compatibility
|
QOI might be worth a look. It is not widespread as exchange format, but quite popular as internal image format in many apps. It has okish compression and is really fast for its small code footprint. |
|
That would be nice to have, indeed. Since it's so little code, it would be easy to audit and fuzz test too. |
|
AVIF and QOI support added, ImageMagick removed. |
4 tasks
stevenwalton
added a commit
to stevenwalton/homebrew-core
that referenced
this issue
Sep 26, 2024
Current formula does not support viewing AVIF (AV1) files nor does it support JPEG-XL files. This is resolved by adding dependencies for libavif and jpeg-xl. Native AVIF format has been supported since version 1.14.0, wherein ImageMagick was removed. Details in chafa 107 and 157 hpjansson/chafa#107 hpjansson/chafa#157
6 tasks
carlocab
pushed a commit
to stevenwalton/homebrew-core
that referenced
this issue
Sep 26, 2024
Current formula does not support viewing AVIF (AV1) files nor does it support JPEG-XL files. This is resolved by adding dependencies for libavif and jpeg-xl. Native AVIF format has been supported since version 1.14.0, wherein ImageMagick was removed. Details in chafa 107 and 157 hpjansson/chafa#107 hpjansson/chafa#157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ImageMagick is a complex dependency that's hard to support. While it's an extremely versatile library, it's also got a kitchen sink approach that includes spawning external processes, causing inadvertent resource exhaustion and security issues. It would be nice to remove this dependency to cut down on risk/maintenance/packaging footprint.
That would leave the
chafaCLI tool with support for the following formats: GIF, JPEG, PNG, SVG, TIFF, WebP, XWD. We may want to add support for AVIF as mentioned in #98 first. Potentially other important image formats too (suggestions welcome).We'd lose support for formats like PDF (which many distributions disable anyway) and all video transcoding via IM (ew!). Users who want to keep using these can pipe to stdin like in the following examples:
ffmpeg -i https://i.imgur.com/sa1Tz6q.mp4 -f gif - | chafa -d infconvert https://oig.nasa.gov/docs/IG-21-025.pdf[0] gif:- | chafa -t 1 --bg white...and the performance will be better too.
The text was updated successfully, but these errors were encountered: