Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.7 #3921

Closed
wants to merge 5 commits into from
Closed

go 1.7 #3921

wants to merge 5 commits into from

Conversation

waits
Copy link
Contributor

@waits waits commented Aug 15, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --new-formula <formula> (after doing brew install <formula>)?

Go 1.7

brew audit go says stable and devel versions are identical, but if I leave devel at 1.7rc6 then it complains about that instead.

@@ -19,7 +17,7 @@ class Go < Formula
sha256 "6ebbafcac53bbbf8c4105fa84b63cca3d6ce04370f5a04ac2ac065782397fc26"
end

go_version = "1.6"
go_version = "1.7"
Copy link
Contributor

@hacfi hacfi Aug 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the :revision to 26c35b4dcf6dfcb924e26828ed9f4d028c5ce05a 🎱

@hacfi
Copy link
Contributor

hacfi commented Aug 16, 2016

There are still 2 references to vet in line 75 and 102 but that can also be cleaned up later I guess.

@douglarek douglarek mentioned this pull request Aug 16, 2016
4 tasks
# 1.6.3 does not build on macOS Sierra. Users should use devel instead
# until 1.7 is stable (due soon).
depends_on MaximumMacOSRequirement => :el_capitan
depends_on MaximumMacOSRequirement => :sierra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just be removed now.

@douglarek
Copy link
Contributor

 # Should use the last stable binary release to bootstrap.
    resource "gobootstrap" do
      url "https://storage.googleapis.com/golang/go1.6.3.darwin-amd64.tar.gz"
      version "1.6.3"
      sha256 "2cd8c824d485a7e73522287278981a528e8f9cb8d3dea41719e29e1bd31ca70a"
    end

@waits
Copy link
Contributor Author

waits commented Aug 16, 2016

1.6.3 doesn't build on Sierra, you sure I should bump the bootstrap version to that?

@douglarek
Copy link
Contributor

@waits golang/go#16354

@waits
Copy link
Contributor Author

waits commented Aug 16, 2016

@douglarek Got it, thanks!

@nathany
Copy link
Contributor

nathany commented Aug 16, 2016

Bootstrapping with Go 1.4 is still an open issue. golang/go#16352

@nathany
Copy link
Contributor

nathany commented Aug 16, 2016

Go 1.6.3 fixed a gettimeofday issue in Sierra beta 3 but it broke again in beta 4. Go 1.7 rc6 provided a new patch. Go 1.7 is rc6 with no code changes.

@douglarek
Copy link
Contributor

==> brew test --verbose godep
==> FAILED
Testing godep
==> Using the sandbox
/usr/bin/sandbox-exec -f /tmp/homebrew20160816-21266-e2iogv.sb /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby -W0 -I /usr/local/Library/Homebrew -- /usr/local/Library/Homebrew/test.rb /usr/local/Library/Taps/homebrew/homebrew-core/Formula/godep.rb --verbose
==> /usr/local/Cellar/godep/74_1/bin/godep path
Error: GO15VENDOREXPERIMENT is enabled and the vendor/ directory is not a valid Go workspace.
Error: godep: failed
Failed executing: /usr/local/Cellar/godep/74_1/bin/godep path
/usr/local/Library/Homebrew/formula.rb:1535:in `block in system'
/usr/local/Library/Homebrew/formula.rb:1472:in `open'
/usr/local/Library/Homebrew/formula.rb:1472:in `system'
/usr/local/Library/Taps/homebrew/homebrew-core/Formula/godep.rb:36:in `block (2 levels) in <class:Godep>'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:125:in `chdir'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:125:in `cd'
/usr/local/Library/Taps/homebrew/homebrew-core/Formula/godep.rb:36:in `block in <class:Godep>'
/usr/local/Library/Homebrew/formula.rb:1377:in `block in run_test'
/usr/local/Library/Homebrew/extend/fileutils.rb:14:in `block in mktemp'
/usr/local/Library/Homebrew/extend/fileutils.rb:75:in `block in run'
/usr/local/Library/Homebrew/extend/fileutils.rb:75:in `chdir'
/usr/local/Library/Homebrew/extend/fileutils.rb:75:in `run'
/usr/local/Library/Homebrew/extend/fileutils.rb:13:in `mktemp'
/usr/local/Library/Homebrew/formula.rb:1371:in `run_test'
/usr/local/Library/Homebrew/test.rb:28:in `block in <main>'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/timeout.rb:66:in `timeout'
/usr/local/Library/Homebrew/test.rb:27:in `<main>'

@waits
Copy link
Contributor Author

waits commented Aug 16, 2016

What should I do about the stable and devel versions are identical error? Of course they're identical, there isn't a dev version out right now. Should I take it out completely?

@waits
Copy link
Contributor Author

waits commented Aug 16, 2016

@hacfi Those are gone now.

@DomT4 DomT4 self-assigned this Aug 16, 2016
@DomT4 DomT4 closed this in eb0e6dc Aug 16, 2016
@DomT4 DomT4 removed their assignment Aug 16, 2016
@DomT4
Copy link
Member

DomT4 commented Aug 16, 2016

Apologies, I borrowed your commit & moved into another PR to adjust a bunch of other "things" ™️.

Your commit was preserved & merged in eb0e6dc. Thank you for your contribution to Homebrew @waits; we appreciate it! 😺

@waits
Copy link
Contributor Author

waits commented Aug 16, 2016

No problem! 🎉

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants