-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go 1.7 #3921
go 1.7 #3921
Conversation
@@ -19,7 +17,7 @@ class Go < Formula | |||
sha256 "6ebbafcac53bbbf8c4105fa84b63cca3d6ce04370f5a04ac2ac065782397fc26" | |||
end | |||
|
|||
go_version = "1.6" | |||
go_version = "1.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the :revision
to 26c35b4dcf6dfcb924e26828ed9f4d028c5ce05a
🎱
There are still 2 references to |
# 1.6.3 does not build on macOS Sierra. Users should use devel instead | ||
# until 1.7 is stable (due soon). | ||
depends_on MaximumMacOSRequirement => :el_capitan | ||
depends_on MaximumMacOSRequirement => :sierra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can just be removed now.
# Should use the last stable binary release to bootstrap.
resource "gobootstrap" do
url "https://storage.googleapis.com/golang/go1.6.3.darwin-amd64.tar.gz"
version "1.6.3"
sha256 "2cd8c824d485a7e73522287278981a528e8f9cb8d3dea41719e29e1bd31ca70a"
end |
1.6.3 doesn't build on Sierra, you sure I should bump the bootstrap version to that? |
@douglarek Got it, thanks! |
Bootstrapping with Go 1.4 is still an open issue. golang/go#16352 |
Go 1.6.3 fixed a gettimeofday issue in Sierra beta 3 but it broke again in beta 4. Go 1.7 rc6 provided a new patch. Go 1.7 is rc6 with no code changes. |
|
What should I do about the |
@hacfi Those are gone now. |
No problem! 🎉 |
brew install <formula>
(where<formula>
is the name of the formula you're submitting)?brew audit --new-formula <formula>
(after doingbrew install <formula>
)?Go 1.7
brew audit go
saysstable and devel versions are identical
, but if I leave devel at 1.7rc6 then it complains about that instead.