build: bootstrapping Go 1.n on macOS Sierra from source #16352

bradfitz · 2016-07-13T18:30:06Z

@andlabs pointed out in #16272 (comment) that as of macOS Sierra, we'll have no way to bootstrap Go 1.N from source.

Maybe we need to backport @ianlancetaylor's time fix to Go 1.4?

bradfitz · 2016-07-13T18:32:31Z

Nevermind. @ianlancetaylor says it works fine on Sierra. You can build Go 1.4 there and time won't work and tests will fail, but it will successfully build Go 1.7.

andlabs · 2016-07-13T18:35:45Z

Good to know. I'm fine with untested 1.4s (the tests take too long to run on my virtual machines so I don't have a choice in those cases =P ); hopefully this won't break something else in the future.

ianlancetaylor · 2016-07-13T20:35:18Z

I'm closing this because I believe that it works fine today.

bradfitz · 2016-08-02T14:17:02Z

As of Sierra Beta 4, this issue is again relevant.

kirillDanshin · 2016-08-03T14:58:56Z

I think we need to backport this fix in 1.4.4 as soon as possible.
we could also wait for Sierra stable release but now folks can't install Go from source.

bradfitz · 2016-08-03T17:02:47Z

@kirillDanshin, we're going to wait until Sierra is released. It's already changed twice during Sierra betas.

kirillDanshin · 2016-08-03T18:05:06Z

ok @bradfitz ping me here when we'll going to backport the fix, I'll do it.

ianlancetaylor · 2016-08-03T18:47:43Z

@kirillDanshin People using a beta version of Sierra and building Go from source should, I hope, be able to apply a patch to their 1.4.3 sources. It doesn't make sense for us to release 1.4.4 now, given that the code in Sierra has changed twice already.

tattwamasi · 2016-08-03T20:21:04Z

~~Has anyone filed a radar with Apple, and would it be worth it to? I was about to, and reference this and related issues, but will reference other IDs if already filed.~~ (Edit: based on conversation in the other issues re: the change, seems like it isn't worth bringing up)

I had a working Go, but the b4 broke it, or I did with something else, so I was (re)installing with brew. Is there a easy(ish) way to build using the 1.4.3 patch with brew, or am I better off just pulling 1.4.3 from git and going from source?

bradfitz · 2016-08-03T20:33:24Z

Apple knows. The right people on both sides know the details. It's Go's fault, anyway, not Apple's.

tattwamasi · 2016-08-03T21:39:49Z

Thanks. And to follow up on the remainder of my comment, I didn't actually need to install from source, and had no reason to have to use brew, so I downloaded the pkg file for 1.7b5 from the main site.

It seems to work fine, and based on the git history should contain the fixes for Sierra (for now at least 😁 )
Now to rebuild Hugo and hopefully stop the frequent, but intermittent, crashes.

bradfitz · 2016-09-09T17:29:47Z

macOS Sierra GM (Gold Master) came out yesterday. The time system call interface is unchanged from Beta 4.

I confirmed that all.bash passes on macOS 10.12 Sierra, using Go 1.7.1 as the GOROOT_BOOTSTRAP. It fails to bootstrap using Go 1.4.3.

So, should we cherry-pick the time fix back to Go 1.4.4 so there's a source-only way to bootstrap on macOS 10.12+?

The cherry picks would be:

fad2bbd (the first change, for Sierra beta2)
2da5633 (the fix for Sierra beta4, and final)
da070be (the syscall package too)

@ianlancetaylor, @rsc?

ianlancetaylor · 2016-09-09T17:50:38Z

I suppose I am mildly in favor of doing a 1.4.4 release for better Darwin support going forward. We should also consider #14795 (https://golang.org/cl/21190) and #13114 (https://golang.org/cl/16982).

mwhudson · 2016-09-11T22:00:04Z

I fixed #13114 on release-branch.go1.4 already (https://go-review.googlesource.com/c/21598/)

Updates #16352 Change-Id: I214c87579ef21ced8d0ba94aa170dd7780afec4b Reviewed-on: https://go-review.googlesource.com/32312 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-on: https://go-review.googlesource.com/32914

bradfitz · 2016-11-10T01:24:54Z

@broady deployed the docs: https://golang.org/doc/install/source#go14

Closing this.

hartzell · 2016-11-19T17:35:26Z

Here's a Go 1.4 source-only snapshot for building on Sierra: https://storage.googleapis.com/golang/go1.4-bootstrap-20161024.tar.gz

@bradfitz -- My reading of the full set of comments here is that if there are other changes needed to keep 1.4 building in the future (even if Apple drops MacOS, etc...) there will be new date-stamped tarballs. Is that correct?

I'm touching up the spack packaging for the bootstrap and can either track the tip of the 1.4 release branch or use tarballs. The project has a mild preference for tarballs because one can verify them with digests.

The last C based Go src tree was the 1.4 series. For a while they were cutting new releases so that people could bootstrap from a C only system. Now they're recommending that you either use the release-1.4 branch or that you use a date-stamped tarball that they'll produce on an as-needed basis. There are several issues that keep 1.4.2 from building on a CentOS 7 system. I've switched to the date based tarball. The cgo bits were also mis-behaving, but they're not needed for the bootstrapping task so I've set an environment variable that disables them. Details [on the install-from-source page](https://golang.org/doc/install/source#go14) and these issues: - golang/go#17545 - golang/go#16352.

bradfitz · 2016-11-19T22:53:52Z

@bradfitz -- My reading of the full set of comments here is that if there are other changes needed to keep 1.4 building in the future (even if Apple drops MacOS, etc...) there will be new date-stamped tarballs. Is that correct?

Yup. That's the idea. If there are changes needed in the future.

hartzell · 2016-11-19T23:30:56Z

@bradfitz Thanks!

* Update go-bootstrap package The last C based Go src tree was the 1.4 series. For a while they were cutting new releases so that people could bootstrap from a C only system. Now they're recommending that you either use the release-1.4 branch or that you use a date-stamped tarball that they'll produce on an as-needed basis. There are several issues that keep 1.4.2 from building on a CentOS 7 system. I've switched to the date based tarball. The cgo bits were also mis-behaving, but they're not needed for the bootstrapping task so I've set an environment variable that disables them. Details [on the install-from-source page](https://golang.org/doc/install/source#go14) and these issues: - golang/go#17545 - golang/go#16352. * Update go package Switched from pulling from the git repository to using the source tarballs and added digest values. Added support for 1.7.3, continued supporting 1.6.2, including patches for a couple of problems (details in [17545](golang/go#17545) and [17986](golang/go#17986). Dropped support for 1.5.4 and 1.4.2 because they no longer pass their tests and the patches above to not apply.

These patches are for two issues: * Enabling Go to build on Alpine by disabling PIC per: golang/go#6940 https://github.com/docker-library/golang/blob/master/1.7/alpine/no-pic.patch * Fixing Go 1.4 bug appearing on macOS 10.12.1 per: golang/go#16352 (comment)

…strap it Otherwise it started to fail this way: [2017-02-22 11:49:22,982] INFO --- FAIL: TestLoadFixed (0.00s) [2017-02-22 11:49:22,982] INFO time_test.go:929: Now().In(loc).Zone() = "-01", -3600, want "GMT+1", -3600 [2017-02-22 11:49:22,983] INFO FAIL [2017-02-22 11:49:22,983] INFO FAIL time 2.380s See golang/go#16352 (comment) and around for details.

gunsluo · 2017-05-11T07:05:40Z

download https://storage.googleapis.com/golang/go1.4-bootstrap-20161024.tar.gz
compile success

@bradfitz Thanks!

Of particular interest are the updates to `./go install languages go` whereby the Go source repo is primed with the `GOROOT_BOOTSTRAP` version in `_prepare_go_repo_for_bootstrap`. This is necessary due to the macOS Sierra issues described in golang/go#16352. The fix is only in the `release-branch.go1.4` branch not a tag, which causes `gvm` not to find it without this priming step.

StudioEtrange · 2017-11-09T03:37:44Z

Still need a "real" binary release of 1.4.4, for some packaging system, some fast bootstraping purpose (without having to build go 1.4.4), or use gonative+gox tools on macos, and so on.

I dont know which problem does it generate to make a binary release instead of just source release ?

Please just release a binary go1.4.4 !

broady · 2017-11-09T03:44:08Z

You can use 1.9.2 for that purpose.

…

On Nov 8, 2017 7:38 PM, "StudioEtrange" ***@***.***> wrote: Still need a "real" binary release of 1.4.4, for some packaging system, some fast boostraping purpose (without having to build go 1.4.4) and so on. I dont know which problem does it generate to make binary release instead of just source release ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16352 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABhlvlPzDBhOwgAw5OkexqckNNuuwnNks5s0nO-gaJpZM4JLtk3> .

StudioEtrange · 2017-11-09T03:50:50Z

No, I cannot use 1.9.2 in some use case, for example for gonative+gox.
At this time gonative+gox on macos sierra is broken. And we just need a binary 1.4.4 release to not have to prebuilt a go1.4.4 before all our other task. Making too long bootstraping.

So, what is the exact problem of releasing 1.4.4 binary ?

broady · 2017-11-09T04:08:09Z

Can you help me understand why you need a 1.4.x binary release?

You can use any recent version of Go to bootstrap an environment to compile from source.

You only need the 1.4.x source to bootstrap if you want to build entirely from source.
If you want a binary release to bootstrap, use the latest stable version (i.e., 1.9.2).

I thought there was an explanation of this somewhere, but I can't find it.

StudioEtrange · 2017-11-09T04:16:23Z

Ok
Crosscompiling chain use gonative+gox. (https://github.com/inconshreveable/gonative)
I think you know this set up.

gonative is a simple tool which creates a build of Go that can cross compile to all platforms while still using the Cgo-enabled versions of the stdlib packages. It does this by downloading the binary distributions for each platform and copying their libraries into the proper places.

Some go application use this setup to cross compile go application.

And for now, gonative needs go1.4 to work. Then it download binaries and prepare cross compiling toolchain, then we use gox to cross compile.

So, getting in first place go1.4.4 (so with patches for macos included) to be built before cross compilation take a while in case of bootstraping chain.

That's a use case of having 1.4.4 binary available

broady · 2017-11-09T04:20:28Z

Why does gonative require go1.4? I find that hard to believe. This sounds like an issue with gonative.

/cc @inconshreveable

StudioEtrange · 2017-11-09T04:23:29Z

Dont know yet.
I investigate in the two direction

why gonative works only on 1.4.x
why there is not a go binary 1.4.4

inconshreveable · 2017-11-09T04:24:22Z

@StudioEtrange gonative is very, very old and almost certainly no longer necessary or the right way to do whatever it is that you're trying to do. i no longer use it and you should consider it a deprecated tool. any issue with it also belongs on that repository and not here

rsc · 2017-11-09T14:41:37Z

Please don't comment on long-closed issues. We don't track them.

bradfitz mentioned this issue Jul 13, 2016

runtime: go1.7beta2 test failures on MacOS 10.12: net/http, runtime, time #16272

Closed

ianlancetaylor closed this as completed Jul 13, 2016

bradfitz reopened this Aug 2, 2016

zchee mentioned this issue Aug 2, 2016

runtime: failed build, compile and use compiled binary on macOS Sierra Beta 4(16A270f) #16570

Closed

bradfitz added the OS-Darwin label Aug 2, 2016

bradfitz mentioned this issue Aug 3, 2016

runtime: Can't build go on MacOS 10.12 public beta 3 #16583

Closed

quentinmit added this to the Go1.4.4 milestone Aug 4, 2016

This was referenced Aug 7, 2016

runtime: Encountering strange build stack trace when running go build #16627

Closed

runtime: panic issues with go get #16634

Closed

runtime: Build interrupted with panic and segmentation fault on OS X Sierra #16669

Closed

nathany mentioned this issue Aug 16, 2016

go 1.7 Homebrew/homebrew-core#3921

Closed

4 tasks

vcabbage mentioned this issue Sep 21, 2016

runtime: can't build go distribution caused by #16272 and #16570 #17182

Closed

ianlancetaylor mentioned this issue Sep 25, 2016

compile: error: shifting a negative signed value. #17183

Closed

This was referenced Sep 27, 2016

runtime: backport 'fix nanotime for macOS Sierra, again' to go 1.6.x maybe #17234

Closed

allow to compile go and go14 without COMPAT_FREEBSD32 and COMPAT_FREEBSD10 #17267

Closed

BramGruneir mentioned this issue Sep 29, 2016

Performance is down after upgrading to macOS Sierra. microsoft/vscode-go#503

Closed

bradfitz closed this as completed Nov 10, 2016

This was referenced Jan 6, 2017

doc: contribute.html doesn't mention GOROOT_BOOTSTRAP #18545

Open

x/website: revise download page (system requirements for stable/archived versions) #18554

Open

yicong2007 mentioned this issue Aug 4, 2017

make tools go-src issue in macOS Sierra, needs special go-bootstrap source Entware/Entware-ng#728

Closed

mbland mentioned this issue Sep 6, 2017

Enable successful install on macOS 10.12.6 mbland/dev-setup#6

Merged

tkbky mentioned this issue Oct 22, 2017

gvm install go1.9rc1 fail moovweb/gvm#272

Open

golang locked and limited conversation to collaborators Nov 9, 2017

rsc unassigned broady Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: bootstrapping Go 1.n on macOS Sierra from source #16352

build: bootstrapping Go 1.n on macOS Sierra from source #16352

bradfitz commented Jul 13, 2016

bradfitz commented Jul 13, 2016

andlabs commented Jul 13, 2016

ianlancetaylor commented Jul 13, 2016

bradfitz commented Aug 2, 2016

kirillDanshin commented Aug 3, 2016

bradfitz commented Aug 3, 2016

kirillDanshin commented Aug 3, 2016

ianlancetaylor commented Aug 3, 2016

tattwamasi commented Aug 3, 2016 •

edited

Loading

bradfitz commented Aug 3, 2016

tattwamasi commented Aug 3, 2016

bradfitz commented Sep 9, 2016

ianlancetaylor commented Sep 9, 2016

mwhudson commented Sep 11, 2016

bradfitz commented Nov 10, 2016

hartzell commented Nov 19, 2016

bradfitz commented Nov 19, 2016

hartzell commented Nov 19, 2016

gunsluo commented May 11, 2017

StudioEtrange commented Nov 9, 2017 •

edited

Loading

broady commented Nov 9, 2017 via email

StudioEtrange commented Nov 9, 2017

broady commented Nov 9, 2017 •

edited

Loading

StudioEtrange commented Nov 9, 2017 •

edited

Loading

broady commented Nov 9, 2017

StudioEtrange commented Nov 9, 2017 •

edited

Loading

inconshreveable commented Nov 9, 2017

rsc commented Nov 9, 2017

build: bootstrapping Go 1.n on macOS Sierra from source #16352

build: bootstrapping Go 1.n on macOS Sierra from source #16352

Comments

bradfitz commented Jul 13, 2016

bradfitz commented Jul 13, 2016

andlabs commented Jul 13, 2016

ianlancetaylor commented Jul 13, 2016

bradfitz commented Aug 2, 2016

kirillDanshin commented Aug 3, 2016

bradfitz commented Aug 3, 2016

kirillDanshin commented Aug 3, 2016

ianlancetaylor commented Aug 3, 2016

tattwamasi commented Aug 3, 2016 • edited Loading

bradfitz commented Aug 3, 2016

tattwamasi commented Aug 3, 2016

bradfitz commented Sep 9, 2016

ianlancetaylor commented Sep 9, 2016

mwhudson commented Sep 11, 2016

bradfitz commented Nov 10, 2016

hartzell commented Nov 19, 2016

bradfitz commented Nov 19, 2016

hartzell commented Nov 19, 2016

gunsluo commented May 11, 2017

StudioEtrange commented Nov 9, 2017 • edited Loading

broady commented Nov 9, 2017 via email

StudioEtrange commented Nov 9, 2017

broady commented Nov 9, 2017 • edited Loading

StudioEtrange commented Nov 9, 2017 • edited Loading

broady commented Nov 9, 2017

StudioEtrange commented Nov 9, 2017 • edited Loading

inconshreveable commented Nov 9, 2017

rsc commented Nov 9, 2017

tattwamasi commented Aug 3, 2016 •

edited

Loading

StudioEtrange commented Nov 9, 2017 •

edited

Loading

broady commented Nov 9, 2017 •

edited

Loading

StudioEtrange commented Nov 9, 2017 •

edited

Loading

StudioEtrange commented Nov 9, 2017 •

edited

Loading