Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riak 2.9.0p1 #40281

Closed
wants to merge 4 commits into from
Closed

riak 2.9.0p1 #40281

wants to merge 4 commits into from

Conversation

chenrui333
Copy link
Member

relates to #40075

@chenrui333
Copy link
Member Author 

17:42:49 following command and follow the instructions in your editor to edit
17:42:49 your configuration file:
17:42:49 
17:42:49     git config --global --edit
17:42:49 
17:42:49 After doing this, you may fix the identity used for this commit with:
17:42:49 
17:42:49     git commit --amend --reset-author
17:42:49 
17:42:49  2 files changed, 5 insertions(+), 1 deletion(-)
17:42:49 Error: An exception occurred within a child process:
17:42:49   Utils::InreplaceError: inreplace failed
17:42:49 rebar.config.lock:
17:42:49   expected replacement of "f6ed834cd8799623ec00faaedc9ef2a55876d5d8" with "f8f763c503171602e218def94b13ea72dabb5599"
17:42:49

zbeekman
zbeekman suggested changes May 25, 2019
View reviewed changes
Copy link
Contributor

@zbeekman zbeekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tweaks for resources... not sure how to address the main problem though.

Formula/riak.rb
@@ -18,12 +18,12 @@ class Riak < Formula
# rebar tries to fetch fuse using git over ssh
resource "fuse" do
url "https://github.com/jlouis/fuse.git",
:revision => "21c6e52ced3af294f2fe636039106068da12eeeb"
:tag => "2.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the :revision this tag points to? People sometimes overwrite tags.

Formula/riak.rb
@@ -44,7 +44,7 @@ class Riak < Formula

resource "yokozuna" do
url "https://github.com/basho/yokozuna.git",
:revision => "b53d999529626301c36fa3efa22b2b0165217556"
:tag => "riak_kv-2.9.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, can we use the :revision that this tag points to? Also, add a comment with the tag to clarify.

@SMillerDev SMillerDev added the build failure CI fails while building the software label Jun 25, 2019
@chenrui333
Copy link
Member Author

No idea about how to fix it, close the PR for now.

@chenrui333 chenrui333 closed this Aug 20, 2019
This was referenced Nov 9, 2019
Closed
Closed
@lock lock bot added the outdated PR was locked due to age label Jan 14, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 14, 2020
@chenrui333 chenrui333 deleted the riak-2.9.0p1 branch December 18, 2022 04:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zbeekman zbeekman zbeekman requested changes

Assignees
No one assigned
Labels
build failure CI fails while building the software outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @zbeekman @SMillerDev