Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL 1.0 removal #46454

Closed
17 tasks done
fxcoudert opened this issue Nov 7, 2019 · 10 comments
Closed
17 tasks done

OpenSSL 1.0 removal #46454

fxcoudert opened this issue Nov 7, 2019 · 10 comments
Labels
outdated PR was locked due to age

Comments

@fxcoudert
Copy link
Member

fxcoudert commented Nov 7, 2019

OpenSSL 1.0 will reach EOL on 2019-12-31. Here are the few remaining formulas that depend on it, and need to be fixed (or removed). They are sorted by analytics (higher usage first):

  • mysql-connector-c
  • erlang@19 (needed by couchdb)
  • rethinkdb
  • freerdp
  • thrift@0.9
  • ruby@2.0
  • erlang@17 (needed by riak)
  • bulk_extractor
  • nut
  • ipmiutil
  • freeswitch
  • libcapn
  • virtuoso
  • pound

Edit: Sadly, we have added new formulas with OpenSSL 1.0 dependency (by mistake)

@Bo98
Copy link
Member

Bo98 commented Nov 7, 2019

freeswitch won't be on that list for too long (#46367).

@fxcoudert
Copy link
Member Author

fxcoudert commented Nov 7, 2019

libcapn

ipmiutil

nut

bulk_extractor

freerdp

rethinkdb

virtuoso

erlang@17 (needed by riak)

@jnozsc
Copy link
Contributor

jnozsc commented Nov 8, 2019

@jnozsc
Copy link
Contributor

jnozsc commented Nov 8, 2019

https://github.com/Homebrew/homebrew-core/blob/master/Formula/ruby@2.0.rb

https://apple.stackexchange.com/questions/47664/what-is-apples-policy-for-supporting-security-updates-on-older-versions-of-os-x

https://apple.stackexchange.com/questions/257627/ruby-version-on-macos-sierra

it seems ruby@2.0 in homebrew-core is kept in order to support Mac OSX 10.12 or prior .
Mac OSX 10.13 has built-in ruby version 2.3.3

So if homebrew-core decide to stop support Mac OSX 10.12 or prior, it should be safe to remove it

@fxcoudert
Copy link
Member Author

@Bo98 we need to migrate mysql-connector-c to its latest version (we ship a very old one). As far as I understand, the distribution of mysql-connector-c has changed, and is now part of the source package for mysql-client. Would you be able to help and provide a PR for updating mysql-connector-c? Many thanks in advance…

@Bo98
Copy link
Member

Bo98 commented Nov 9, 2019

I'll need to check what the actual differences are. You're right that I think it merged into mysql-client but I'm not sure why they were separate things to begin with. I'll try create something using mysql-connector-c and see if it's compatible with mysql-client.

We should definitely also offer mysql-client 8.0. I'm not sure why there's a comment saying to use 5.7 when a mysql-client@5.7 seems a viable option.

I'll get back to you shortly.

@Bo98
Copy link
Member

Bo98 commented Nov 10, 2019

Linking the relevant mysql-connector-c pull request here for reference: #46566

@efiop
Copy link
Contributor

efiop commented Nov 17, 2019

Hi guys!

Sorry for accidentally using 1.0 in dvc. Created #46829 to fix that.

Thanks for maintaining homebrew 🙏 !

@v-stickykeys
Copy link

Just curious. Why the removal?

@SMillerDev
Copy link
Member

Because of the first sentence in the issue.

@lock lock bot added the outdated PR was locked due to age label Jan 28, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

No branches or pull requests

6 participants