Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to OpenSSL 1.1.1 #745

Closed
anton-trunov opened this issue Jan 7, 2020 · 3 comments
Closed

Switch to OpenSSL 1.1.1 #745

anton-trunov opened this issue Jan 7, 2020 · 3 comments

Comments

@anton-trunov
Copy link
Contributor

anton-trunov commented Jan 7, 2020

According to https://www.openssl.org/policies/releasestrat.html,

Version 1.0.2 will be supported until 2019-12-31 (LTS).

But

Version 1.1.1 will be supported until 2023-09-11 (LTS).

Incidentally, macOS's Homebrew package manager already dropped 1.0.2, see Homebrew/homebrew-core#46454

@anton-trunov
Copy link
Contributor Author

FWIW, a related issue -- #690

@anton-trunov
Copy link
Contributor Author

Also, I've seen a couple reports saying OpenSSL 1.1.1 works fine (although I don't know if the reporters ran the tests or just compiled Scilla). On macOS 10.14.6 Mojave OpenSSL v1.1.1 compiles fine, but the tests fail:

ulimit -s 128 -n 1024; dune exec tests/polynomials/testsuite_polynomials.exe
........
Ran: 8 tests in: 0.15 seconds.
OK
ulimit -s 128 -n 1024; dune exec tests/base/testsuite_base.exe -- -print-diff true
...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................EE..........................
==============================================================================
Error: all_tests:4:signature_tests:0:schnorr_tests:1.

File "/Users/anton/zilliqa/scilla/_build/oUnit-all_tests-Antons-MacBook-Pro.local#00.log", line 8454, characters 1-1:
Error: all_tests:4:signature_tests:0:schnorr_tests:1 (in the log).

Worker stops running: Killed by signal -10
------------------------------------------------------------------------------
==============================================================================
Error: all_tests:4:signature_tests:0:schnorr_tests:0.

File "/Users/anton/zilliqa/scilla/_build/oUnit-all_tests-Antons-MacBook-Pro.local#00.log", line 8450, characters 1-1:
Error: all_tests:4:signature_tests:0:schnorr_tests:0 (in the log).

Worker stops running: Killed by signal -10
------------------------------------------------------------------------------
Ran: 519 tests in: 9.78 seconds.
FAILED: Cases: 519 Tried: 519 Errors: 2 Failures: 0 Skip:  0 Todo: 0 Timeouts: 0.
make: *** [test] Error 1

Also, the CI currently uses version 1.0.2

@anton-trunov
Copy link
Contributor Author

Fixed with PR #746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant