Fix Schnorr #746
Merged
Fix Schnorr #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2020 01:14
Looks like it failed before on OpenSSL 1.1.1 because of null pointer dereferences
|
LGTM, but please wait for @bb111189 to approve. |
|
@bb111189 Incidentally, should we add you as a codeowner for all the C/C++ files in Scilla? |
vaivaswatha
approved these changes
Jan 8, 2020
bb111189
approved these changes
Jan 8, 2020
vyorkin
added a commit
to vyorkin/scilla
that referenced
this pull request
Jan 14, 2020
* master: Fix bug/typo to check patterns in transitions (Zilliqa#752) Scilla runner refactoring + a small bug fix (Zilliqa#749) Fix Schnorr (Zilliqa#746) Fix init JSON validation checks for libraries (Zilliqa#748) Rearranging lib test files (Zilliqa#747) INSTALL.md formatting: add foldable sections (Zilliqa#744) Remove unused tests (Zilliqa#741) Disallow duplicate _extlib entries and updates to library import tests (Zilliqa#743) Use domt4 homebrew tap (Zilliqa#742)
vyorkin
added a commit
that referenced
this pull request
Jan 21, 2020
* master: Run `dune build @fmt` in Travis. On a diff, it'll fail (#761) Conform entire source base to ocamlformat (#760) Add an ocamlformat Makefile target. (#759) Warnings and gas output must not always be in JSON format (#757) Tweaks to build system (#755) Prepare for 0.5.1 release (#754) Fix opam build by making libff a git submodule (#753) Test/libtest (#751) Fix bug/typo to check patterns in transitions (#752) Scilla runner refactoring + a small bug fix (#749) Fix Schnorr (#746) Fix init JSON validation checks for libraries (#748) Rearranging lib test files (#747) INSTALL.md formatting: add foldable sections (#744) Remove unused tests (#741) Disallow duplicate _extlib entries and updates to library import tests (#743) Use domt4 homebrew tap (#742)
This was referenced Feb 16, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation with OpenSSL 1.1.1 on macOS (see #745 (comment)).