Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow duplicate _extlib entries and updates to library import tests #743

Merged
merged 7 commits into from
Jan 3, 2020
Merged

Disallow duplicate _extlib entries and updates to library import tests #743

merged 7 commits into from
Jan 3, 2020

Conversation

vaivaswatha
Copy link
Contributor

@vaivaswatha vaivaswatha commented Jan 3, 2020 •
edited
Loading

Reference: #478

@vaivaswatha vaivaswatha changed the title Fix a comment in a test for extlibs Updates to library import tests Jan 3, 2020
@vaivaswatha
Copy link
Contributor Author

vaivaswatha commented Jan 3, 2020 •
edited
Loading

  • Disallow duplicate entries in _extlibs field of init JSON
  • Add checker test that imports a library, with init json entry
  • Fix a comment in a test for extlibs

@vaivaswatha vaivaswatha changed the title Updates to library import tests Disallow duplicate _extlib entries and updates to library import tests Jan 3, 2020
@vaivaswatha vaivaswatha merged commit 673be99 into master Jan 3, 2020
@vaivaswatha vaivaswatha deleted the test_fix branch January 3, 2020 10:19
vyorkin added a commit to vyorkin/scilla that referenced this pull request Jan 14, 2020
@vyorkin
Merge branch 'master' into perf-benchmarks
1b4f594 
* master:
  Fix bug/typo to check patterns in transitions (Zilliqa#752)
  Scilla runner refactoring + a small bug fix (Zilliqa#749)
  Fix Schnorr (Zilliqa#746)
  Fix init JSON validation checks for libraries (Zilliqa#748)
  Rearranging lib test files (Zilliqa#747)
  INSTALL.md formatting: add foldable sections (Zilliqa#744)
  Remove unused tests (Zilliqa#741)
  Disallow duplicate _extlib entries and updates to library import tests (Zilliqa#743)
  Use domt4 homebrew tap (Zilliqa#742)
vyorkin added a commit that referenced this pull request Jan 21, 2020
@vyorkin
Merge branch 'master' into scilla-server
08f5cc9 
* master:
  Run `dune build @fmt` in Travis. On a diff, it'll fail (#761)
  Conform entire source base to ocamlformat (#760)
  Add an ocamlformat Makefile target. (#759)
  Warnings and gas output must not always be in JSON format (#757)
  Tweaks to build system (#755)
  Prepare for 0.5.1 release (#754)
  Fix opam build by making libff a git submodule (#753)
  Test/libtest (#751)
  Fix bug/typo to check patterns in transitions (#752)
  Scilla runner refactoring + a small bug fix (#749)
  Fix Schnorr (#746)
  Fix init JSON validation checks for libraries (#748)
  Rearranging lib test files (#747)
  INSTALL.md formatting: add foldable sections (#744)
  Remove unused tests (#741)
  Disallow duplicate _extlib entries and updates to library import tests (#743)
  Use domt4 homebrew tap (#742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@jjcnn jjcnn Awaiting requested review from jjcnn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaivaswatha @anton-trunov