Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awsume 4.0.0 (new formula) #45270

Closed
wants to merge 2 commits into from
Closed

awsume 4.0.0 (new formula) #45270

wants to merge 2 commits into from

Conversation

GGeethanjali
Copy link
Contributor

Added new formula - awsume 4.0.0

@chenrui333
Copy link
Member

@GGeethanjali Can you update the commit message format as formular version (new formula)? Thanks!

@chenrui333 chenrui333 added the new formula PR adds a new formula to Homebrew/homebrew-core label Oct 13, 2019
bfontaine
bfontaine reviewed Oct 14, 2019
View reviewed changes
Formula/awsume.rb Outdated Show resolved Hide resolved
@GGeethanjali GGeethanjali changed the title Awsume awsume 4.0.0 (new formula) Oct 14, 2019
@chenrui333
Copy link
Member

13:50:12 ==> /usr/local/Cellar/awsume/4.0.0/bin/awsume -v
13:50:12 4.0.0
13:50:12 Error: awsume: failed
13:50:12 An exception occurred within a child process:
13:50:12 ArgumentError: wrong number of arguments (given 0, expected 1)

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Oct 14, 2019
@alebcay alebcay removed the test failure CI fails while running the test-do block label Oct 21, 2019
@chenrui333
Copy link
Member

Thanks @GGeethanjali for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

@fxcoudert
Copy link
Member 

depends_on "openssl"

No, please don't 😢
We are actively getting rid of OpenSSL 1.0: #46454 and it should definitely not be introduced in new formulas

@fxcoudert fxcoudert mentioned this pull request Nov 17, 2019
Closed
17 tasks
@lock lock bot added the outdated PR was locked due to age label Jan 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bfontaine bfontaine bfontaine left review comments

Assignees
No one assigned
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GGeethanjali @chenrui333 @fxcoudert @bfontaine @alebcay