Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-client 5.7.28 #46357

Closed
wants to merge 1 commit into from
Closed

mysql-client 5.7.28 #46357

wants to merge 1 commit into from

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Nov 5, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

I want to take this opportunity to ask however why this formula is pinned at 5.7. There is no explanatory reason provided. Why not create a mysql-client@5.7?

@Bo98
Copy link
Member Author

Bo98 commented Nov 6, 2019

The build failure is unrelated to this pull request it seems. It would appear to be a problem caused by a libgcrypt update.

@Bo98
Copy link
Member Author

Bo98 commented Nov 6, 2019

#46369

@Bo98
Copy link
Member Author

Bo98 commented Nov 6, 2019

Should be ready for a retest.

@SMillerDev
Copy link
Member

@BrewTestBot test this please!

@Bo98
Copy link
Member Author

Bo98 commented Nov 6, 2019

Again seems to be something not caused by me.

The mysql-connector-c++@1.1 bottles are missing for Mojave and High Sierra. How has that happened and what is the best way to get them rebuilt?

@Bo98
Copy link
Member Author

Bo98 commented Nov 6, 2019

Ah source link is dead. Seems like there's a 1.1.13 too.

I'll get that sorted.

@Bo98
Copy link
Member Author

Bo98 commented Nov 7, 2019

#46415 is now merged. Requesting retest.

@fxcoudert
Copy link
Member

@BrewTestBot test this please

@Bo98
Copy link
Member Author

Bo98 commented Nov 8, 2019

07:43:26 running bootstrap script ... 2019-11-08 07:43:19.940 GMT [78316] FATAL: could not create shared memory segment: No space left on device
07:43:26 2019-11-08 07:43:19.940 GMT [78316] DETAIL: Failed system call was shmget(key=5432001, size=56, 03600).
07:43:26 2019-11-08 07:43:19.940 GMT [78316] HINT: This error does not mean that you have run out of disk space. It occurs either if all available shared memory IDs have been taken, in which case you need to raise the SHMMNI parameter in your kernel, or because the system's overall limit for shared memory has been reached.

I don't think I can fix this one.

@fxcoudert
Copy link
Member

That's fine, we know what the problem is, so we can ignore it for now…

@fxcoudert fxcoudert closed this in c6bcf29 Nov 8, 2019
@Bo98 Bo98 deleted the mysql-client branch November 8, 2019 10:05
@fxcoudert
Copy link
Member

Hi @Bo98, as part of fixing #46454 we need to migrate mysql-connector-c to its latest version (we ship a very old one). As far as I understand, the distribution of mysql-connector-c has changed, and is now part of the source package for mysql-client. Would you be able to help and provide a PR for updating mysql-connector-c? Many thanks in advance…

@lock lock bot added the outdated PR was locked due to age label Jan 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants