Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildifier|buildozer: disable because they're not compiling anymore #71330

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request formula disabled Formula disabled no ARM bottle Formula has no ARM bottle labels Feb 17, 2021
@carlocab
Copy link
Member

You forgot to split your commits 😅

carlocab
carlocab previously approved these changes Feb 17, 2021
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Feb 18, 2021
@carlocab carlocab merged commit e3879c8 into Homebrew:master Feb 18, 2021
@Loyalsoldier
Copy link
Contributor

Actually in Go v1.16, we can just use go install github.com/bazelbuild/buildtools/buildifier@version and go install github.com/bazelbuild/buildtools/buildozer@version to build and install them.

@carlocab
Copy link
Member

@Loyalsoldier this was attempted in #70924 and #70921, but didn't work out. If you know how to fix it, please do open a PR. Thanks!

@Loyalsoldier
Copy link
Contributor

@carlocab I have filed an issue to upstream bazelbuild/buildtools#961

Hope they would switch to Go modules instead. And if they don't like the idea, we then can use go install github.com/bazelbuild/buildtools/buildifier@version to build and install it, after Go formula updated to v1.16 in Homebrew.

@Bo98
Copy link
Member

Bo98 commented Feb 18, 2021

Bazel should be enough to guarantee reproducibility, without the need for Go modules. I don't know why bazelisk is used here, but I think should discontinue using that. It doesn't have the patches we apply to Bazel and is also likely why these builds were not reproducible since it downloads varying versions of bazel binaries.

@Loyalsoldier
Copy link
Contributor

Loyalsoldier commented Mar 1, 2021

Since upstream has enabled go module for buildifier and buildozer in commit bazelbuild/buildtools@f2aed9e . I think it's time to re-enable these two formulas.

@SMillerDev
Copy link
Member Author

Please make a pull request to fix the builds and re-enable the formula once that commit has actually landed in a release.

@Loyalsoldier
Copy link
Contributor

Please make a pull request to fix the builds and re-enable the formula once that commit has actually landed in a release.

Done in #72219 and #72220

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Apr 1, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
formula disabled Formula disabled no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants