Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildifier 4.0.1 #72219

Closed
wants to merge 1 commit into from
Closed

buildifier 4.0.1 #72219

wants to merge 1 commit into from

Conversation

Loyalsoldier
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle labels Mar 1, 2021
@Loyalsoldier
Copy link
Contributor Author

Since upstream has released a new version(v4.0.1) that uses Go modules. It's time to re-enable this.

@Loyalsoldier Loyalsoldier mentioned this pull request Mar 1, 2021
Merged
5 tasks
carlocab
carlocab previously approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Loyalsoldier.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @carlocab bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review March 1, 2021 12:17

bottle publish failed

carlocab
carlocab previously approved these changes Mar 1, 2021
View reviewed changes
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review March 1, 2021 12:22

bottle publish failed

carlocab
carlocab previously approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like GitHub Actions still aren't working properly yet. But, well, third time's the charm?

@Loyalsoldier
Copy link
Contributor Author

Do I need to place the built binary somewhere so that homebrew knows where to find it?

system "go", "build", *std_go_args, "./buildifier"

or

system "go", "build", *std_go_args, "./buildifier" "-o" "#{bin}/buildifier"

@carlocab
Copy link
Member

carlocab commented Mar 1, 2021

-o bin/"buildifier" is already part of std_go_args, so what you've done is fine.

@carlocab carlocab added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Mar 1, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review March 1, 2021 13:19

bottle publish failed

carlocab
carlocab previously approved these changes Mar 1, 2021
View reviewed changes
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review March 1, 2021 14:17

bottle publish failed

@Loyalsoldier
Copy link
Contributor Author

One day, the BrewTestBot becomes Ultron 🤖️😂

carlocab
carlocab previously approved these changes Mar 1, 2021
View reviewed changes
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review March 1, 2021 15:16

bottle publish failed

carlocab
carlocab previously approved these changes Mar 2, 2021
View reviewed changes
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @carlocab bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review March 2, 2021 03:43

bottle publish failed

@Loyalsoldier
Copy link
Contributor Author

Any progress?

SMillerDev
SMillerDev previously approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this again

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed SMillerDev’s stale review March 2, 2021 09:18

bottle publish failed

@carlocab carlocab closed this in d09f5c0 Mar 2, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev left review comments

@carlocab carlocab carlocab left review comments

Assignees
No one assigned
Labels
CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. go Go use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Loyalsoldier @BrewTestBot @carlocab @SMillerDev