Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deterministic key generation using pseudo randomness #1033

Merged
merged 2 commits into from
Oct 16, 2021
Merged

deterministic key generation using pseudo randomness #1033

merged 2 commits into from
Oct 16, 2021

Conversation

cocoliliace
Copy link
Contributor

@cocoliliace cocoliliace commented Oct 15, 2021

What?

Copy of #924 due to the history rewrite.

Why?

To allow documents created by this library to be identical. It's useful for testings. See #537, #923.

How?

Use pseudo randomness instead of pure randomness so that the random numbers are deterministic but still distinct.

Testing?

All tests passed.

New Dependencies?

No

Screenshots

N/A

Suggested Reading?

No

Anything Else?

Checklist

  • I read CONTRIBUTING.md.
  • I read MAINTAINERSHIP.md#pull-requests.
  • I added/updated unit tests for my changes.
  • I added/updated integration tests for my changes.
  • I ran the integration tests.
  • I tested my changes in Node, Deno, and the browser.
  • I viewed documents produced with my changes in Adobe Acrobat, Foxit Reader, Firefox, and Chrome.
  • I added/updated doc comments for any new/modified public APIs.
  • My changes work for both new and existing PDF files.
  • I ran the linter on my changes.

Copy link
Owner

@Hopding Hopding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @ChingChang9! This will go out in the next release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants