Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key reuse bug #1078

Merged
merged 6 commits into from
Nov 6, 2021
Merged

Fix key reuse bug #1078

merged 6 commits into from
Nov 6, 2021

Conversation

Hopding
Copy link
Owner

@Hopding Hopding commented Nov 6, 2021

What?

Fixes a bug introduced in #1033 that allows Font, XObject, etc... keys to be overwritten.

Why?

Fixes #1075.

How?

Continue to use deterministic random number generation, but check if the generated key conflicts with an existing one. Keep generating new keys until there's not a conflict.

Testing?

Added unit tests and ran integration tests.

New Dependencies?

No

Screenshots

N/A

Suggested Reading?

Yes

Anything Else?

N/A

Checklist

  • I read CONTRIBUTING.md.
  • I read MAINTAINERSHIP.md#pull-requests.
  • I added/updated unit tests for my changes.
  • I added/updated integration tests for my changes.
  • I ran the integration tests.
  • I tested my changes in Node, Deno, and the browser.
  • I viewed documents produced with my changes in Adobe Acrobat, Foxit Reader, Firefox, and Chrome.
  • I added/updated doc comments for any new/modified public APIs.
  • My changes work for both new and existing PDF files.
  • I ran the linter on my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#1033 broke image insertion for loaded documents
1 participant