Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Reduce hospitalization memory pressure #263

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Conversation

samshah
Copy link
Collaborator

@samshah samshah commented Apr 28, 2020

Switch a critical split-apply-combine away from do.call(), which results in a 45% reduction in memory usage and a 35% speedup in execution time in my testing.

Switch a critical split-apply-combine away from `do.call()`, which results in a 45% reduction in memory usage and a 35% speedup in execution time in my testing.
@samshah samshah requested review from jkamins7, jwills and kkintaro April 28, 2020 03:28
@jkamins7
Copy link
Contributor

dang, i should almost always be using that instead of group_map

Copy link
Collaborator

@jwills jwills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🎉 🔥

@jkamins7 jkamins7 merged commit c4df091 into dev Apr 28, 2020
@samshah samshah deleted the hospitalization_memory_opt branch April 28, 2020 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants