Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add a --no-logo flag #158

Closed
petdance opened this issue Aug 26, 2024 · 8 comments
Closed

[FEATURE] Add a --no-logo flag #158

petdance opened this issue Aug 26, 2024 · 8 comments
Assignees
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Milestone

Comments

@petdance
Copy link

Describe the solution you'd like

I'd like to be able to run archey without the ASCII art. It's nice the first dozen times but after that, it's noise. All my boxen are RHEL anyway, so it's never helpful for me to have a visual indicator.

Describe alternatives you've considered

I've poked in the config.json, and looked at the code, and I don't see anything that allows the logo to be skipped. I did try hacking up my /usr/local/lib/python3.6/site-packages/archey/logos/rhel.py to have LOGOS only contain empty strings. That works OK, although it does leave a three-space gutter on the left. I'd rather not have to Ansible out a hacked version of that file to all my machines if I don't have to.

@HorlogeSkynet
Copy link
Owner

Hello @petdance ! Sure, let's include such an option in the next release 🙂

@HorlogeSkynet HorlogeSkynet added this to the v4.15.0.0 milestone Aug 26, 2024
@HorlogeSkynet HorlogeSkynet added the enhancement ⬆️ Implements a new feature, fixes or improves existing ones label Aug 26, 2024
@HorlogeSkynet HorlogeSkynet self-assigned this Aug 26, 2024
@petdance
Copy link
Author

Sounds good. Is there something you need me to do? I'm not sure who "us" in "let's include" is.

@HorlogeSkynet
Copy link
Owner

I'll try to implement that, if you could stay around to review/test the feature it would already be awesome.

@petdance
Copy link
Author

Just let me know and I can try things out. I'm not well versed in installing Python packages, though, so it may be a learning experience for me.

@HorlogeSkynet
Copy link
Owner

Hey @petdance, please see #159 for implementation proposal.
If you clone the Git project and checkout the feat/no_logo branch, you can then execute the following commands to run Archey from sources :

python3 -m venv venv && source venv/bin/activate
pip install -e .
python3 -m archey --logo-style none

Thanks for your time, bye 👋

@petdance
Copy link
Author

It works for me.

One thing I note is that the labels in the output take on the color of COLORS[0] but since there are no colors with --logo-style none, the labels are always just plain text. That's not a problem to me. Just observing.

@HorlogeSkynet
Copy link
Owner

Indeed, entry colors are based on "main" logo colors. Without loading a logo, this implantation cannot infer any color for entries 🤡

Although, entries_color configuration option should still apply, WDYT about the global idea here ?

Thanks bye 👋

@petdance
Copy link
Author

I don't have a concern about it. I was pointing it out. It's all good with me.

@github-staff github-staff deleted a comment from Lxx-c Oct 23, 2024
@github-staff github-staff deleted a comment from Lxx-c Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⬆️ Implements a new feature, fixes or improves existing ones
Projects
None yet
Development

No branches or pull requests

4 participants
@petdance @HorlogeSkynet and others