Merge pull request #349 from joshgk00/issue/issue-345

Fixes Transaction.Items is null first time ProcessTransaction is called
HotcakesCommerce · Feb 23, 2021 · afdac96 · afdac96
2 parents f166643 + f00ccd5
commit afdac96
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Libraries/Hotcakes.Commerce/BusinessRules/OrderTasks/ReceiveCreditCards.cs b/Libraries/Hotcakes.Commerce/BusinessRules/OrderTasks/ReceiveCreditCards.cs
@@ -108,11 +108,12 @@ private bool ProcessTransaction(OrderTaskContext context, OrderTransaction p)
 			try
 			{
 				var payManager = new OrderPaymentManager(context.Order, context.HccApp);
+                var orderNumber = !string.IsNullOrEmpty(p.OrderNumber) ? p.OrderNumber : context.Order.OrderNumber;
 				Transaction t = payManager.CreateEmptyTransaction();
 				t.Card = p.CreditCard;
 				t.Card.SecurityCode = context.Inputs.GetProperty("hcc", "CardSecurityCode");
 				t.Amount = p.Amount;
-                t.Items = GetLineItemsForTransaction(context, p.OrderNumber);
+                t.Items = GetLineItemsForTransaction(context, orderNumber);
 
 				if (context.HccApp.CurrentStore.Settings.PaymentCreditCardAuthorizeOnly)
 				{