Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Transaction.Items is null first time ProcessTransaction is called #349

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Conversation

joshgk00
Copy link
Contributor

Resolves #345 by using the OrderTaskContext.Order.OrderNumber as a fallback in case the OrderNumber on the Transaction object is empty

…e OrderNumber on the OrderTransaction object is an empty string
@WillStrohl WillStrohl added this to the 03.06.00 milestone Feb 23, 2021
@WillStrohl WillStrohl added the bug label Feb 23, 2021
@WillStrohl
Copy link
Member

Outstanding stuff. Thank you!

@WillStrohl WillStrohl merged commit afdac96 into HotcakesCommerce:development Feb 23, 2021
@joshgk00 joshgk00 deleted the issue/issue-345 branch February 23, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Custom gateway class -- Transaction.Items is null first time ProcessTransaction is called
2 participants