Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proj inbound calling #150

Merged
merged 52 commits into from
Mar 4, 2024
Merged

Proj inbound calling #150

merged 52 commits into from
Mar 4, 2024

Conversation

alonso-cadenas
Copy link
Collaborator

@alonso-cadenas alonso-cadenas commented Aug 17, 2023

Description

Jira Ticket: CALL-5895

This PR aims at adding support for following new features.

  • inbound calling feature
  • caller id match on incoming call
  • navigate to record if caller id match is found
  • availability status change
  • Inbound calling support in demo apps

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

esme and others added 9 commits June 16, 2023 09:46
* Create incoming call started method to test inbound calling
* Refactor constants

* Refactor version constant

* 0.1.6-alpha.0

* Remove sdkVersion prop from initialized event

* 0.1.6-alpha.1

* Introduce inbound calling availability events

* Test new events

* Configure prettier and format the demo-minimal-js html. Improve accessibility and SEO.

* Use semantic html and style buttons

* Refactor switch case into onclick methods and remove logic that waits for DOM content loaded since we are using defer to load the JS

* Rename id

* Specify encoding

* Match SDK event name

* sort props

* Initialize as logged out

* Add user availability events

* Prevent window overflow

* Allow user to change availability during a call.

* disable availability buttons during a call.

* 0.1.7-alpha.0

* Use new alpha version
Create event handlers for create_engagement_succeeded and create_engagement_failed
* Initialize SDK on ready event

* Save userAvailable state in the demo widget

* Allow user to start an incoming call asynchronously for testing (#146)
* Initialize SDK on ready event

* Save userAvailable state in the demo widget

* Allow user to start an incoming call asynchronously for testing (#146)

* Revert "Allow user to start an incoming call asynchronously for testing (#146)"

This reverts commit 9800470.

---------

Co-authored-by: Esme Ling <esmelingyr@gmail.com>
Co-authored-by: Esme <23175119+esme@users.noreply.github.com>
@alonso-cadenas alonso-cadenas requested a review from a team as a code owner August 17, 2023 15:30
@alonso-cadenas alonso-cadenas marked this pull request as draft August 17, 2023 15:31
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-150/
on branch gh-pages at 2024-03-04 19:13 UTC

Copy link
Contributor

@hemang-thakkar hemang-thakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hemang-thakkar and others added 3 commits November 30, 2023 10:12
* Add support for inbound calling to react demo app

* Add unit tests for Incoming Screen

* Unit tests

* Fix useCti hook to store incomingNumber

* Feedback fixes # 1

* Feedback fixes #2

* Feedback fixes
* Send navigate_to_record event when we receive an existing call id

* Fix console debug message const

* Navigate to record page in the react demo app (#165)

* Update README with instructions for redirect

* 0.2.1-alpha.3

* Use next tag of SDK
@hemang-thakkar hemang-thakkar marked this pull request as ready for review February 20, 2024 18:18
@alonso-cadenas alonso-cadenas mentioned this pull request Feb 27, 2024
1 task
hemang-thakkar and others added 3 commits March 4, 2024 10:20
* Add beta badge to incoming call, availability toggles

* code review feedback

* fix unit tests
@alonso-cadenas
Copy link
Collaborator Author

Good to merge!

@hemang-thakkar hemang-thakkar merged commit 9bd1521 into master Mar 4, 2024
1 check passed
@hemang-thakkar hemang-thakkar deleted the proj-inbound-calling branch March 4, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants