-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proj inbound calling #150
Merged
Merged
Proj inbound calling #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create incoming call started method to test inbound calling
* Refactor constants * Refactor version constant * 0.1.6-alpha.0 * Remove sdkVersion prop from initialized event * 0.1.6-alpha.1 * Introduce inbound calling availability events * Test new events * Configure prettier and format the demo-minimal-js html. Improve accessibility and SEO. * Use semantic html and style buttons * Refactor switch case into onclick methods and remove logic that waits for DOM content loaded since we are using defer to load the JS * Rename id * Specify encoding * Match SDK event name * sort props * Initialize as logged out * Add user availability events * Prevent window overflow * Allow user to change availability during a call. * disable availability buttons during a call. * 0.1.7-alpha.0 * Use new alpha version
Create event handlers for create_engagement_succeeded and create_engagement_failed
* Initialize SDK on ready event * Save userAvailable state in the demo widget * Allow user to start an incoming call asynchronously for testing (#146)
* Initialize SDK on ready event * Save userAvailable state in the demo widget * Allow user to start an incoming call asynchronously for testing (#146) * Revert "Allow user to start an incoming call asynchronously for testing (#146)" This reverts commit 9800470. --------- Co-authored-by: Esme Ling <esmelingyr@gmail.com> Co-authored-by: Esme <23175119+esme@users.noreply.github.com>
|
esme
force-pushed
the
proj-inbound-calling
branch
from
October 23, 2023 23:14
50bae54
to
1c8d87e
Compare
* Add events for caller id matching * Add caller id match payload * Add debugMessageType argument to logging * Add incomingCall event handler to README * Log last sync event
hemang-thakkar
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add support for inbound calling to react demo app * Add unit tests for Incoming Screen * Unit tests * Fix useCti hook to store incomingNumber * Feedback fixes # 1 * Feedback fixes #2 * Feedback fixes
* Send navigate_to_record event when we receive an existing call id * Fix console debug message const * Navigate to record page in the react demo app (#165) * Update README with instructions for redirect * 0.2.1-alpha.3 * Use next tag of SDK
alonso-cadenas
commented
Feb 28, 2024
esme
approved these changes
Feb 29, 2024
* Add beta badge to incoming call, availability toggles * code review feedback * fix unit tests
Good to merge! |
* Simplify README.md * Update link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira Ticket: CALL-5895
This PR aims at adding support for following new features.
Merge Checklist
BRAVE Checklist