Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error to message types #173

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

alonso-cadenas
Copy link
Collaborator

Description

Jira Ticket: CALL-5885

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

@alonso-cadenas alonso-cadenas marked this pull request as ready for review February 9, 2024 16:50
@alonso-cadenas alonso-cadenas requested a review from a team as a code owner February 9, 2024 16:50
Copy link

github-actions bot commented Feb 9, 2024

PR Preview Action v1.4.4
🚀 Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-173/
on branch gh-pages at 2024-02-09 16:50 UTC

Copy link
Contributor

@hemang-thakkar hemang-thakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alonso-cadenas alonso-cadenas merged commit 3a7c5cd into proj-inbound-calling Feb 9, 2024
1 check passed
@alonso-cadenas alonso-cadenas deleted the call-5885 branch February 9, 2024 17:11
hemang-thakkar added a commit that referenced this pull request Mar 4, 2024
* Create incoming call method to test inbound calling (#130)

* Create incoming call started method to test inbound calling

* Introduce inbound calling availability events (#138)

* Refactor constants

* Refactor version constant

* 0.1.6-alpha.0

* Remove sdkVersion prop from initialized event

* 0.1.6-alpha.1

* Introduce inbound calling availability events

* Test new events

* Configure prettier and format the demo-minimal-js html. Improve accessibility and SEO.

* Use semantic html and style buttons

* Refactor switch case into onclick methods and remove logic that waits for DOM content loaded since we are using defer to load the JS

* Rename id

* Specify encoding

* Match SDK event name

* sort props

* Initialize as logged out

* Add user availability events

* Prevent window overflow

* Allow user to change availability during a call.

* disable availability buttons during a call.

* 0.1.7-alpha.0

* Use new alpha version

* Send incoming call event with data to create an engagement (#140)

Create event handlers for create_engagement_succeeded and create_engagement_failed

* Add to number for inbound calling

* Initialize demo widget when ready event is received from HubSpot (#145)

* Initialize SDK on ready event

* Save userAvailable state in the demo widget

* Allow user to start an incoming call asynchronously for testing (#146)

* Revert "Initialize demo widget when ready event is received from HubSpot (#145)" (#147)

This reverts commit 4aa4ff6.

* Extensions inbound lifecycle (#148)

* Initialize SDK on ready event

* Save userAvailable state in the demo widget

* Allow user to start an incoming call asynchronously for testing (#146)

* Revert "Allow user to start an incoming call asynchronously for testing (#146)"

This reverts commit 9800470.

---------

Co-authored-by: Esme Ling <esmelingyr@gmail.com>
Co-authored-by: Esme <23175119+esme@users.noreply.github.com>

* 0.1.8-alpha.0

* Use next tag of SDK

* 0.2.1-alpha.0

* Use latest sdk version

* Caller id match (#156)

* Add events for caller id matching

* Add caller id match payload

* Add debugMessageType argument to logging

* Add incomingCall event handler to README

* Log last sync event

* 0.2.1-alpha.1

* Use next tag of SDK

* 0.2.1-alpha.2

* Use next tag of SDK

* Add support for inbound calling to react demo app (#157)

* Add support for inbound calling to react demo app

* Add unit tests for Incoming Screen

* Unit tests

* Fix useCti hook to store incomingNumber

* Feedback fixes # 1

* Feedback fixes #2

* Feedback fixes

* Add publish script for inbound branch (#162)

* Send navigate_to_record event when we receive an existing call id (#158)

* Send navigate_to_record event when we receive an existing call id

* Fix console debug message const

* Navigate to record page in the react demo app (#165)

* Update README with instructions for redirect

* 0.2.1-alpha.3

* Use next tag of SDK

* Configure workflow to run on workflow_dispatch event

* React Demo App: Set incoming number and contact name in localstorage  (#166)

* React Demo App: Set incoming number and contact info in localstorage on redirect

* feedback fixes

* 0.2.2-alpha.0

* 0.2.2-beta.0

* Support NAVIGATE_TO_RECORD_FAILED event (#171)

* switch case lost its case to dictionary

* Handle NAVIGATE_TO_RECORD_FAILED

* Add event handler to demos

* Remove unused message handler

* Restore master version

* 0.3.0-0

* 0.3.0-rc.0

* 0.3.0-alpha.0

* 0.3.0-beta.0

* Update dependents

* Add error to message types (#173)

* Restore alpha version before bumping

* 0.3.0-alpha.1

* 0.3.0-alpha.2

* Update dependents

* 0.3.0-beta.0

* 0.3.0-beta.1

* Bump sdk version to 0.3.0-beta.1 in demos

* removing empty tag from preview.yml

* Add beta badge to incoming call, availability toggles (#179)

* Add beta badge to incoming call, availability toggles

* code review feedback

* fix unit tests

* Simplify formatting

* Simplify formatting

* fix height for react demo app

* Simplify README.md (#177)

* Simplify README.md

* Update link

---------

Co-authored-by: Esme <23175119+esme@users.noreply.github.com>
Co-authored-by: Esme Ling <esmelingyr@gmail.com>
Co-authored-by: hemang-thakkar <59508898+hemang-thakkar@users.noreply.github.com>
Co-authored-by: hthakkar <hthakkar@hubspot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants