Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project download endpoint (Other half in hubspot-cli) #23

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

kemmerle
Copy link
Contributor

@kemmerle kemmerle commented Aug 1, 2023

Description and Context

I'm refactoring the project download command to use a different download endpoint (/archive-full) that downloads the project's src folder and hsproject.json.

See the other half of this work in the hubspot-cli PR. Instructions on testing will be provided there.

Who to Notify

@brandenrodgers @camden11

@brandenrodgers
Copy link
Contributor

Will this new download endpoint work if the project already has a hsproject.json in it?

@kemmerle
Copy link
Contributor Author

kemmerle commented Aug 1, 2023

@brandenrodgers, I'm a little confused by the phrasing of this question, but I'll do my best to answer what I think you're asking.

I've eliminated the step in the download command, where we generate the hsproject.json because it's no longer needed. Now we download a project into a folder with the project name, with a structure like this:

--sampleProject
----src
----hsproject.json (This is downloaded directly now)

So customers can even download a project within a project if they're so inclined. Let me know if that makes sense.

Copy link
Contributor

@camden11 camden11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kemmerle kemmerle merged commit fb20dd8 into main Aug 3, 2023
@kemmerle kemmerle deleted the refactor/project-download branch August 3, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants