Refactor hs project download (Other half in cli-lib)
#907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
approved these changes
Aug 2, 2023
brandenrodgers
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Currently, there is a bug in the
hs project downloadcommand, in which the command will not run outside a project directory. I was able to fix this issue by eliminating an unnecessary call to get a project config.I also refactored the download command to use a different download endpoint (
/archive-full) that downloads thesrcof the project folder and thehsproject.json(see the other part of this work in the cli-lib PR).To test out this PR, you will need to check out the above branch in the cli-lib repo and then use the yarn link @hubspot/cli-lib command to use the symlinked local package. Docs for more details.
Who to Notify
@brandenrodgers @camden11