Audio zone fixes #4278
Merged
Audio zone fixes #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianpeiris
suggested changes
May 22, 2021
src/components/player-info.js
Outdated
| @@ -120,12 +120,16 @@ AFRAME.registerComponent("player-info", { | |||
| this.updateDisplayNameFromPresenceMeta(e.detail); | |||
| }, | |||
| updateDisplayNameFromPresenceMeta(presenceMeta) { | |||
There was a problem hiding this comment.
Looks like the contents of this function has drifted from its behavior. Maybe updatePlayerInfoFromPresenceMeta?
| "pin_objects", | ||
| "spawn_emoji", | ||
| "fly" | ||
| ]); |
There was a problem hiding this comment.
Yeah at first I was like "Wait, js has an array concatenation operator? And then I realized what was going on... Oh javascript. Funny that it just happened to work mostly correctly by chance.
There was a problem hiding this comment.
Ah good to see it's fixed, noticed that a year ago and I was just about to push a PR for that!
I wondered too at first if I was missing some obscure syntax XD
Co-authored-by: Brian Peiris <brianpeiris@gmail.com>
…to audio-zone-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amplify_audiopermission added in Add amplify_audio permission reticulum#499 to enforcemodOnlyon zone audio sources. Previously this was using "owner" but this does not work well for bound rooms.includesmethod which happened to also be correct for this case. Oh javascript.