Feature Request: Allow MaxUnit and MinUnit for TimeSpan

[deadlydog]

First off, this is a great package. Well done :)

Right now you have the ability to specify a precision integer for TimeSpans. This is great for hard-coded TimeSpans, but isn't flexible enough for calculated ones. In my scenario, I want to always have the TimeSpan represented down to the second, whether the time span is for 5 minutes or 5 days. Ideally I'm looking to be able to do something like:

(timeSpan1 - timeSpan2).Humanize(minUnit: TimeUnit.Second)

which would generate a string like:
"5 minutes, 15 seconds"
or
"2 days, 3 hours, 2 minutes, 33 seconds"

And to go along with that, being able to specify a maxUnit would be great too, so if I had also specified maxUnit: TimeUnit.Hour, then the above string would have been:
"51 hours, 2 minutes, 33 seconds"

Right now the documentation in the ReadMe.md says that maxUnit exists, but it is not in the latest stable NuGet package, which is currently 1.33.7. Maybe it's just still in a feature branch and not yet pushed to the NuGet Gallery?

[MehdiK]

Thanks for the nice words and suggestion @deadlydog

Funny you should mention this as maxUnit was implemented just a couple of days ago :) As you said it's not on nuget yet (will be in the next few minutes).

minUnit would be a nice addition too. Did you want to send us a PR? It should be relatively easy to implement on top of maxUnit.

[alimeziane]

Hi, I would like to work on this subject to participate in your project, that I find very useful. Is anyone treating this evolution or can I start it directly?
Thanks

[MehdiK]

Thanks @blackding. Cool. Go forth and conquer!
On 09/04/2015 7:29 PM, "BlackDing" notifications@github.com wrote:

Hi, I would like to work on this subject to participate in your project,
that I find very useful. Is anyone treating this evolution or can I start
it directly?
Thanks

—
Reply to this email directly or view it on GitHub
#388 (comment).

[danielbrezoi]

Hi, I like this project and I rely want to participate. I have worked on this issue and now I want to sync the changes.
Sorry i haven't announce my intention, I hope it is OK.
Thanks.

[MehdiK]

Closed by #403