Added TimeSpan minUnit option #388 #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have refactor the code so that it will be easy to implement the transformation to years and months. This actually is what I want to do next, if it is OK with you, but I don't know how to make the transformation from days. e.g. 1 year = 365 days and 4 years = (3x365) + (1x366) . I need some opinions on this. |
PublicApiApprovalTest pass fixed Humanizr#403
MehdiK
added a commit
that referenced
this pull request
May 24, 2015
Added TimeSpan minUnit option #388
|
Thanks for the contribution. This is now available on nuget as v1.36.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have add timeSpan minUnit option.