Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change "error" to "failed" #142

Merged
merged 2 commits into from
Apr 23, 2021
Merged

change "error" to "failed" #142

merged 2 commits into from
Apr 23, 2021

Conversation

rayashworth
Copy link
Contributor

The deployed_status can only be "configuring", "deployed", or "failed".

@rayashworth rayashworth mentioned this pull request Apr 22, 2021
Closed
websterc87
websterc87 requested changes Apr 23, 2021
View reviewed changes
Copy link
Collaborator

@websterc87 websterc87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel would should check for both error and failed

I have seen error in the past either their API has changed or both error and failed are possible. I suspect the later.

websterc87
websterc87 approved these changes Apr 23, 2021
View reviewed changes
Copy link
Collaborator

@websterc87 websterc87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to fyre developer only those three are possible so thats good then

@rayashworth rayashworth merged commit 5c09a0c into IBM:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@websterc87 websterc87 websterc87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rayashworth @websterc87 @octravis