Implement pipeline support for TAZ unit tests #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
M-DLB
reviewed
Nov 6, 2024
build-conf/datasets.properties
Outdated
| @@ -69,8 +69,8 @@ SEQAMOD= | |||
| # Optional IDz Load Library. Example: FEL.V14R0M0.SFELLOAD | |||
| SFELLOAD= | |||
|
|
|||
| # Optional IDZ zUnit / WAZI VTP library containing necessary copybooks. Example : FEL.V14R2.SBZUSAMP | |||
| SBZUSAMP= | |||
| # Optional IBM Debug Tool library necessary TAZ copybooks. Example : DEBUG.V16.SEQASAMP | |||
There was a problem hiding this comment.
Generally it is optional, but obviously required when the user is leveraging TAZ
languages/Cobol.groovy
Outdated
| @@ -246,7 +246,7 @@ def createCompileCommand(String buildFile, LogicalFile logicalFile, String membe | |||
|
|
|||
| // add additional zunit libraries | |||
| if (isZUnitTestCase) | |||
| compile.dd(new DDStatement().dsn(props.SBZUSAMP).options("shr")) | |||
| compile.dd(new DDStatement().dsn(props.SEQASAMP).options("shr")) | |||
There was a problem hiding this comment.
In there an indentation issue here?
languages/TazUnitTest.groovy
Outdated
| props.error = "true" | ||
| String errorMsg = "*! zUnit Test Job ${zUnitRunJCL.submittedJobId} failed with ${zUnitRunJCL.maxRC}" | ||
| String errorMsg = "*! The zunit test failed with RC=($rc) for $buildFile " |
There was a problem hiding this comment.
Suggested change
| String errorMsg = "*! The zunit test failed with RC=($rc) for $buildFile " | |
| String errorMsg = "*! The TAZ Unit Test failed with RC=$rc for '$buildFile'" |
| @@ -30,7 +30,7 @@ SCSQLOAD | MQ Load Library. Example: CSQ.V9R1M0.SCSQLOAD | |||
| SDSNLOAD | DB2 Load Library. Example: DB2.V9R1M0.SDSNLOAD | |||
| SDSNEXIT | DB2 Exit Library. Example: DBC0CFG.SDSNEXIT | |||
| SFELLOAD | Optional IDz Load Library. Example: FEL.V14R0M0.SFELLOAD | |||
| SBZUSAMP | Optional z/OS Dynamic Test Runner IDz zUnit / WAZI VTP library containing necessary copybooks. Example : FEL.V14R2.SBZUSAMP | |||
| SEQASAMP | Optional IBM Debug Tool library containing necessary TAZ copybooks. Example : DEBUG.V16.SEQASAMP | |||
There was a problem hiding this comment.
Required for TAZ, but optional for a normal Cobol build.
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Co-authored-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
Co-authored-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
* Provide deployType for object decks Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
feature/560-support-for-taz-early-development-tests-unit-tests # Conflicts: # languages/Cobol.groovy
M-DLB
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Just realized the property jobCard is in application.properties, and could be shared with other language scripts.
Would it make sense to move it to the TAZUnitTest.properties and use a better property name like tazunittest_jobCard, and provide a default value?
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
|
@M-DLB Introduced a dedicated job card property for the taz unit tests, and uplifted a couple of properties in the with the recent commits. Can you please have another check? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dropping the support for IDZ Zunit test setup, and introduces TAZ Unit test support in zAppBuild.