Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(errors): wrap errors from external authenticators to use new system #214

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix(errors): wrap errors from external authenticators to use new system #214

merged 1 commit into from
Apr 8, 2024

Commits on Apr 8, 2024

  1. fix(errors): wrap errors from external authenticators to use new system 

    External authenticators may not use our error types. We previously assumed
that errors coming from the `Authenticate` method would be either an
`AuthenticationError` or `SDKProblem` and performed a type-cast that could
cause a panic. This makes the type checking more explicit, and in the case
of an unexpected error type, wraps the error in a new SDKProblem object and
returns it to keep our error types consistent.

Signed-off-by: Dustin Popp <dpopp07@gmail.com>
    @dpopp07
    dpopp07 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    d186501 View commit details
    Browse the repository at this point in the history